[configurationwebhooks] Code generation: update services and models#1799
[configurationwebhooks] Code generation: update services and models#1799
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new data models and webhook handling logic to support mandate notifications, specifically focusing on BACS Direct Debit. It also updates the description of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new models and webhook handling for Mandate notifications. The changes include adding MandateNotificationRequest, Mandate, MandateBankAccount, MandateBankAccountAccountIdentification, MandateNotificationData, MandatePartyIdentification, and UKLocalMandateAccountIdentification classes. Additionally, the ConfigurationWebhooksHandler has been updated to include a method for processing MandateNotificationRequest.
My review identified several areas for improvement related to error handling consistency and code efficiency, particularly in how enum values are validated and how null values are managed during deserialization. Addressing these points will enhance the robustness and maintainability of the new code.
...main/java/com/adyen/model/configurationwebhooks/MandateBankAccountAccountIdentification.java
Show resolved
Hide resolved
src/main/java/com/adyen/model/configurationwebhooks/ConfigurationWebhooksHandler.java
Show resolved
Hide resolved
...main/java/com/adyen/model/configurationwebhooks/MandateBankAccountAccountIdentification.java
Show resolved
Hide resolved
src/main/java/com/adyen/model/configurationwebhooks/MandateNotificationRequest.java
Show resolved
Hide resolved
src/main/java/com/adyen/model/configurationwebhooks/UKLocalMandateAccountIdentification.java
Show resolved
Hide resolved
c61e878 to
59f950d
Compare
59f950d to
4c31949
Compare
|
Added test for parsing Changes:
All tests passing ✅ |
This PR contains the automated changes for the
configurationwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.