Skip to content

[configurationwebhooks] Code generation: update services and models#1799

Merged
gcatanese merged 2 commits intomainfrom
sdk-automation/configurationwebhooks
Mar 25, 2026
Merged

[configurationwebhooks] Code generation: update services and models#1799
gcatanese merged 2 commits intomainfrom
sdk-automation/configurationwebhooks

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

This PR contains the automated changes for the configurationwebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners March 18, 2026 16:00
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new data models and webhook handling logic to support mandate notifications, specifically focusing on BACS Direct Debit. It also updates the description of the settlementDelayDays field in PlatformPaymentConfiguration to provide more clarity.

Highlights

  • Mandate Webhook Handling: Introduced new models and webhook handler logic for processing mandate-related notifications.
  • BACS Direct Debit Support: Added specific support for BACS Direct Debit mandates, including new data models and webhook types.
  • Settlement Delay Days Update: Updated the description for settlementDelayDays in PlatformPaymentConfiguration to clarify the requirement of enabling Custom Sales Day Payout.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new models and webhook handling for Mandate notifications. The changes include adding MandateNotificationRequest, Mandate, MandateBankAccount, MandateBankAccountAccountIdentification, MandateNotificationData, MandatePartyIdentification, and UKLocalMandateAccountIdentification classes. Additionally, the ConfigurationWebhooksHandler has been updated to include a method for processing MandateNotificationRequest.

My review identified several areas for improvement related to error handling consistency and code efficiency, particularly in how enum values are validated and how null values are managed during deserialization. Addressing these points will enhance the robustness and maintainability of the new code.

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/configurationwebhooks branch from c61e878 to 59f950d Compare March 20, 2026 10:38
@gcatanese gcatanese added the Feature Indicates a new feature addition label Mar 24, 2026
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/configurationwebhooks branch from 59f950d to 4c31949 Compare March 24, 2026 10:26
@gcatanese
Copy link
Copy Markdown
Contributor

Added test for parsing MandateNotificationRequest webhook (balancePlatform.mandate.created).

Changes:

  • Created mock JSON file: src/test/resources/mocks/balancePlatform-webhooks/configuration-mandate-created.json
  • Added test method testMandateCreatedNotificationRequest() in BalancePlatformWebhooksTest.java
  • Test validates mandate details including balance account ID, payment instrument ID, status, type, and UK Local account identification (account number, sort code)

All tests passing ✅

@gcatanese gcatanese added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit ff7a75d Mar 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Indicates a new feature addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants