feat: Add tests and implement real Zod validation utilities#215
Merged
Penielka merged 1 commit intoJul 1, 2026
Merged
Conversation
Replaces stub validation functions with proper Zod schema validation and adds comprehensive test coverage for services and controllers to meet the 80% coverage threshold. Validation Changes: - Add Zod dependency and validation schemas for email, assignment, submission, and course data - Implement validateSchema with proper error handling and formatting - Add isEmail using Zod email validation - Return structured validation results with detailed error messages Test Coverage Additions: - Add AnalyticsService tests covering cache logic, error handling, aggregation methods, and report generation - Add UserController tests for all endpoint handlers including profile, settings, achievements, stats, role, and permissions - Add validation utility tests for all validation functions Files Added: - tests/services/analyticsService.test.ts - tests/controllers/userController.test.ts - tests/utils/validation.test.ts Files Modified: - src/utils/validation.ts (implement real Zod validation)
Contributor
Author
|
@Penielka please, review. |
Penielka
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces stub validation utilities with proper Zod schema validation and adds comprehensive tests for services and controllers to meet the 80% coverage threshold across branches, functions, lines, and statements.
Fixes #21
Architecture Decision Records
docs/adr/NNN-title.mdfollowing the ADR templatedocs/adr/NNN-title.md) — I have marked it as SupersededType of Change
Checklist:
Closes #21