added aria pressed for better accessibility in filter buttons, and state management of pressed button in ExecutionFIltes#189
Open
iammohitvs wants to merge 3 commits intoAgent-Field:mainfrom
Conversation
…ate management of pressed button in ExecutionFIltes
Author
|
Let me know if this is acceptable, and what changes I can make! P.S. Couldnt find the formatter command for the vite app, so i wasnt able to run it, so the formatting for the edited components might differ from the rest. If there is one that i missed, please do let me know and i will run the formatter! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-pressedattributes added to filters for better accesibility. also added a visual indicator of which execution filter is being pressed by tracking the state.Testing
./scripts/test-all.shChecklist
CHANGELOG.md(or this change does not warrant a changelog entry).Screenshots (if UI-related)
Execution FIlters (
ExecutionFilters.tsx):Quick FIlters (
QuickFilters.tsx):Related issues
Fixes #117