fix(p0): close governance fail-open vulnerabilities#83
Merged
Conversation
- govern-shell.sh: use jq --arg for safe JSON construction (fixes #75 printf injection) - govern-shell.sh: use jq for output parsing, fail-closed on governance unavailable (fixes #67) - cmd/shellforge/main.go: fail-closed on JSON unmarshal error and stdin read error (fixes #62) - internal/governance/engine.go: wildcard-only timeout policy no longer matches every command (fixes #58) - agentguard.yaml: block all rm (not just -rf/-fr), fix misleading mode comment (fixes #69, #59) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jpleva91
added a commit
that referenced
this pull request
Mar 30, 2026
- P0 COMPLETE: PRs #83/#84/#85 merged, all P0 governance bugs closed - Issue #59 closed (already fixed by PR #83) - PR #86 opened: fix P1 #28 β governance timeout override (60s cap removed) - PR budget: 1/3 (was 3/3 at-limit) - Dogfood (#76) unblocked from governance side β needs human trigger - P1 remaining: #28 (in PR #86), #63/#68 (qa-agent) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 tasks
jpleva91
added a commit
that referenced
this pull request
Mar 30, 2026
- P0 COMPLETE: PRs #83/#84/#85 merged, all P0 governance bugs closed - Issue #59 closed (already fixed by PR #83) - PR #86 opened: fix P1 #28 β governance timeout override (60s cap removed) - PR budget: 1/3 (was 3/3 at-limit) - Dogfood (#76) unblocked from governance side β needs human trigger - P1 remaining: #28 (in PR #86), #63/#68 (qa-agent) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 3 P0 governance security bugs plus 2 closely related P1s. These were blocking the dogfood run and represent actual security correctness holes in the enforcement runtime.
rmandrm -rnot blocked by no-destructive-rmΒ #69 + agentguard.yaml: misleading comment says 'monitor' but mode is 'enforce'Β #59 fix (agentguard.yaml): Block all rm (not just -rf/-fr); fix misleading mode commentTest plan
Closes #58, #59, #62, #67, #69, #75
Generated with Claude Code