Skip to content

fix(governance): honour policy timeout in shell execution — remove 60s cap (#28) #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpleva91 merged 1 commit into from
Mar 30, 2026
Merged

fix(governance): honour policy timeout in shell execution — remove 60s cap (#28) #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions internal/tools/rtk_shell.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ return runShellRaw(command, timeoutSec)
}

timeout := time.Duration(timeoutSec) * time.Second
if timeout > 60*time.Second {
timeout = 60 * time.Second
}

// RTK wraps the command: rtk sh -c "command"
cmd := exec.Command("rtk", "sh", "-c", command)
Expand Down Expand Up @@ -58,9 +55,6 @@ return Result{Success: false, Output: "Command timed out", Error: "timeout"}

func runShellRaw(command string, timeoutSec int) Result {
timeout := time.Duration(timeoutSec) * time.Second
if timeout > 60*time.Second {
timeout = 60 * time.Second
}
cmd := exec.Command("sh", "-c", command)

done := make(chan error, 1)
Expand Down
Loading