Skip to content

fix(normalizer): word-boundary check in classifyShellRisk — closes #63 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpleva91 merged 1 commit into from
Mar 30, 2026
+5 −3
Merged

fix(normalizer): word-boundary check in classifyShellRisk — closes #63 #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions internal/normalizer/normalizer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,11 @@ func classifyShellRisk(command string) action.RiskLevel {
}
}

// Check read-only patterns: command must START with one of these.
for _, prefix := range readOnlyCommands {
if strings.HasPrefix(trimmed, prefix) {
// Check read-only patterns: command must be exactly the token or start with
// "<token> " (space boundary) to avoid matching longer commands that share a
// prefix (e.g. "catalog_tool" matching "cat", "finder.sh" matching "find").
for _, cmd := range readOnlyCommands {
if trimmed == cmd || strings.HasPrefix(trimmed, cmd+" ") {
return action.RiskReadOnly
}
}
Expand Down
Loading