fix: update silent review examples#110
Merged
Merged
Conversation
remove old graphic code Signed-off-by: Jason Tsay <jason.tsay@ibm.com>
Signed-off-by: Jason Tsay <jason.tsay@ibm.com>
Signed-off-by: Jason Tsay <jason.tsay@ibm.com>
Signed-off-by: Jason Tsay <jason.tsay@ibm.com>
Signed-off-by: Jason Tsay <jason.tsay@ibm.com>
Signed-off-by: Jason Tsay <jason.tsay@ibm.com>
Signed-off-by: Jason Tsay <jason.tsay@ibm.com>
OsherElhadad
pushed a commit
to OsherElhadad/agent-lifecycle-toolkit
that referenced
this pull request
May 5, 2026
* fix: update silent review examples remove old graphic code Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * fix: update onnxruntime version for py3.10 Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * move onnxruntime to main dep list Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * explicit version for 3.10 Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * fix formatting Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * fix silent error unit test Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * skip flaky test Signed-off-by: Jason Tsay <jason.tsay@ibm.com> --------- Signed-off-by: Jason Tsay <jason.tsay@ibm.com> Signed-off-by: Osher-Elhadad <Osher.Elhadad@ibm.com>
OsherElhadad
pushed a commit
to OsherElhadad/agent-lifecycle-toolkit
that referenced
this pull request
May 5, 2026
* fix: update silent review examples remove old graphic code Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * fix: update onnxruntime version for py3.10 Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * move onnxruntime to main dep list Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * explicit version for 3.10 Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * fix formatting Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * fix silent error unit test Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * skip flaky test Signed-off-by: Jason Tsay <jason.tsay@ibm.com> --------- Signed-off-by: Jason Tsay <jason.tsay@ibm.com> Signed-off-by: Osher-Elhadad <Osher.Elhadad@ibm.com>
jsntsay
added a commit
that referenced
this pull request
May 7, 2026
…actionable recommendations (#112) * fix: update silent review examples (#110) * fix: update silent review examples remove old graphic code Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * fix: update onnxruntime version for py3.10 Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * move onnxruntime to main dep list Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * explicit version for 3.10 Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * fix formatting Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * fix silent error unit test Signed-off-by: Jason Tsay <jason.tsay@ibm.com> * skip flaky test Signed-off-by: Jason Tsay <jason.tsay@ibm.com> --------- Signed-off-by: Jason Tsay <jason.tsay@ibm.com> Signed-off-by: Osher-Elhadad <Osher.Elhadad@ibm.com> * chore: bump version to 0.10.1 [skip ci] Signed-off-by: Osher-Elhadad <Osher.Elhadad@ibm.com> * feat: add compact-tool-schema mode, runtime pipeline flag, and SPARC actionable recommendations - Add compact_tool_schema ('auto'|'never'|'always') and compact_tool_threshold config fields to SPARCReflectionConfig for scalable function-selection prompts - Add runtime_pipeline flag to switch between fast runtime prompts and evaluation-time prompts that return actionable unified-diff recommendations - Add SPARCRecommendation / SPARCRecommendationTarget types and _rubric_score, _rubric_confidence, _extract_recommendations helpers in sparc.py - Add CompactMode adapter with compact tool-inventory rendering in adapters.py - Restructure SPARC metric JSON files (general, function_selection, parameter) with runtime variants; add common_principles.py for shared metric principles - Update semantic_checker.py and transformation_prompts.py for new pipeline modes - Update output_parser.py with significant improvements - Add comprehensive test suite: compact schema adapter, eval metrics schema, no benchmark leakage, reflection score, runtime prompts, transformation prompts, and validating LLM client tests Signed-off-by: Osher-Elhadad <Osher.Elhadad@ibm.com> * feat: Format with black Signed-off-by: Osher-Elhadad <Osher.Elhadad@ibm.com> * feat: ruff format Signed-off-by: Osher-Elhadad <Osher.Elhadad@ibm.com> * fix: specify ValidationError in tests for invalid config modes and thresholds Signed-off-by: Osher-Elhadad <Osher.Elhadad@ibm.com> * fix: remove unnecessary variable assignment in TestSafeParse Signed-off-by: Osher-Elhadad <Osher.Elhadad@ibm.com> --------- Signed-off-by: Jason Tsay <jason.tsay@ibm.com> Signed-off-by: Osher-Elhadad <Osher.Elhadad@ibm.com> Co-authored-by: Jason Tsay <jason.tsay@ibm.com> Co-authored-by: github-actions <actions@users.noreply.github.com> Co-authored-by: Osher-Elhadad <Osher.Elhadad@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the old silent review examples to instead use a post-tool node instead of the tool itself. Fixes a few other related bugs that popped up while doing so.