Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| // Only show the Cost column when at least one report has reliable cost data | ||
| // (currently only OpenCode populates cost; Claude and Codex return null) | ||
| const hasCost = Array.from(reports.values()).some((r) => typeof r.cost === 'number' && r.cost > 0); | ||
| const hasBudget = workflowBudget?.limit !== undefined || stepBudgets.size > 0; |
Contributor
There was a problem hiding this comment.
🟡 hasBudget check incorrectly treats null limit as a defined budget due to !== undefined
At packages/sdk/src/workflows/run-summary-table.ts:75, the condition workflowBudget?.limit !== undefined evaluates to true when limit is null, because null !== undefined is true in JavaScript. The buildWorkflowBudgetSummary method in packages/sdk/src/workflows/runner.ts:1541-1544 produces { used, limit: null, over: false } when per-agent constraints exist but no workflow tokenBudget is set. This causes the Budget column to appear in the summary table even when there is no meaningful budget data to display — all cells render as --.
Suggested change
| const hasBudget = workflowBudget?.limit !== undefined || stepBudgets.size > 0; | |
| const hasBudget = (workflowBudget?.limit != null) || stepBudgets.size > 0; |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements runtime token budget enforcement for workflow steps in the SDK.
This adds a shared BudgetTracker and wires it into the workflow runner so token usage is no longer just collected post-hoc. The runner now:
Changes
Validation
Notes