Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/linear/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,19 @@
"description": "Linear adapter bootstrap package for Relayfile",
"type": "module",
"main": "dist/index.js",
"types": "./src/index.ts",
"types": "dist/index.d.ts",
"exports": {
".": "./src/index.ts"
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js"
},
"./path-mapper": {
"types": "./dist/path-mapper.d.ts",
"import": "./dist/path-mapper.js"
}
},
"files": [
"src"
"dist"
],
Comment on lines 18 to 20
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add prepare build for dist-only package contents

Publishing only dist here makes git/file installs fragile because this package has no prepare script to generate dist before packing. prepublishOnly runs for npm publish, but it does not run when users install directly from a Git URL or local path, so the tarball can end up with just package.json and imports then fail at runtime with missing ./dist/*.js files.

Useful? React with πŸ‘Β / πŸ‘Ž.

"scripts": {
"typecheck": "tsc --noEmit -p tsconfig.json",
Expand Down
14 changes: 10 additions & 4 deletions packages/slack/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,19 @@
"type": "module",
"sideEffects": false,
"main": "dist/index.js",
"types": "./src/index.ts",
"types": "dist/index.d.ts",
"exports": {
".": "./src/index.ts"
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js"
},
"./path-mapper": {
"types": "./dist/path-mapper.d.ts",
"import": "./dist/path-mapper.js"
}
},
"files": [
"src",
"tsconfig.json"
"dist"
],
Comment on lines 19 to 21
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add prepare build for dist-only package contents

This change has the same packaging regression as linear: with files restricted to dist and no prepare hook, installs from Git/local sources do not build artifacts before pack time. In those environments prepublishOnly is skipped, so consumers can receive a package without dist/index.js and hit module resolution failures immediately.

Useful? React with πŸ‘Β / πŸ‘Ž.

"scripts": {
"test": "node --import tsx --test src/__tests__/*.test.ts",
Expand Down
Loading