-
Notifications
You must be signed in to change notification settings - Fork 0
fix(linear,slack): point exports to dist/, add ./path-mapper subpath #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,13 +5,19 @@ | |
| "type": "module", | ||
| "sideEffects": false, | ||
| "main": "dist/index.js", | ||
| "types": "./src/index.ts", | ||
| "types": "dist/index.d.ts", | ||
| "exports": { | ||
| ".": "./src/index.ts" | ||
| ".": { | ||
| "types": "./dist/index.d.ts", | ||
| "import": "./dist/index.js" | ||
| }, | ||
| "./path-mapper": { | ||
| "types": "./dist/path-mapper.d.ts", | ||
| "import": "./dist/path-mapper.js" | ||
| } | ||
| }, | ||
| "files": [ | ||
| "src", | ||
| "tsconfig.json" | ||
| "dist" | ||
| ], | ||
|
Comment on lines
19
to
21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This change has the same packaging regression as linear: with Useful? React with πΒ / π. |
||
| "scripts": { | ||
| "test": "node --import tsx --test src/__tests__/*.test.ts", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Publishing only
disthere makes git/file installs fragile because this package has nopreparescript to generatedistbefore packing.prepublishOnlyruns fornpm publish, but it does not run when users install directly from a Git URL or local path, so the tarball can end up with justpackage.jsonand imports then fail at runtime with missing./dist/*.jsfiles.Useful? React with πΒ / π.