feat(linear): support milestones and roadmaps in adapter#22
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8120badaa7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| const author = comment.user as LinearUser | null | undefined; | ||
| if (author) { | ||
| relations.add(linearUserPath(author.id)); |
There was a problem hiding this comment.
Avoid calling linearUserPath(author.id) unless author.id is a non-empty string. In computeSemantics for comments, a payload can contain a user object without an id (or with an empty id) while still providing user_id/author_id; this new call throws inside path encoding and causes the entire ingest path to fail instead of using the fallback identifiers you added below. This is a functional regression for partial/synced comment payloads.
Useful? React with 👍 / 👎.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Address PR review: - `applyCommentSemantics` called `linearUserPath(author.id)` without checking that `author.id` was a non-empty string; with a partial `user` payload this threw in path encoding and aborted the whole ingest instead of letting the `user_id`/`author_id` fallback apply. - `LinearUser` had snake_case companions for every camelCase field except `displayName`, so `user.display_name` (read by `applyUserSemantics`) resolved to `unknown` via the escape hatch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 participant
Summary
Verification