fix(sidebar): make project row hover icons clickable and non-overlapping#2161
Open
i-trytoohard wants to merge 1 commit into
Open
Conversation
Three bugs in mc-sidebar.css prevented the project row action icons (dashboard, orchestrator, kebab menu) from working properly: 1. Icons overlap text: padding-right was 78px but 3 icons (24px each) + gaps + offset need ~80px. Bumped to 84px. 2. Icons not clickable: the session count badge faded to opacity:0 on hover but kept pointer-events:auto, intercepting clicks at the icon boundary. Added pointer-events:none. 3. Icons only work on the second project row: the absolute-positioned actions container had no z-index, so session rows (position:relative, later in DOM) painted on top and blocked hover/click. Added z-index:10. Reported by aditi in #bug-triaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three bugs with the project row hover action icons (dashboard, orchestrator, kebab menu) in the sidebar.
Reported by @aditi in #bug-triaging: "the 3 icons on the session show up while hovering but can't click on it. also they appear only for the second session not the first"
Bug 1 — Icons overlap text
padding-right: 78pxon hover was insufficient for 3 icons (24px × 3) + 2 gaps (1px × 2) + 6px right offset = 80px needed. The project name text ran under the icons.Fix: Bumped to
84px.Bug 2 — Icons not clickable
The session count badge (
.proj-count) faded toopacity: 0on hover but keptpointer-events: auto. The invisible count span sat on top of the action icons and intercepted clicks.Fix: Added
pointer-events: noneto the count on hover.Bug 3 — Icons only work on the second project row
The absolute-positioned actions container (
.proj-actions) had noz-index. Session rows below it in the DOM haveposition: relative(creating stacking contexts that paint on top). When the first project is expanded with sessions underneath, those session rows' stacking context covered the project row's action icons, intercepting hover/click events.Fix: Added
z-index: 10to.project-sidebar__proj-actions.Test Plan
pnpm --filter @aoagents/ao-web typecheck— passespnpm --filter @aoagents/ao-web build— passesChanged Files
packages/web/src/app/mc-sidebar.css— 3 CSS fixes (8 insertions, 2 deletions)