Feat/resolved api base url#206
Merged
mikewheeleer merged 6 commits intoJun 29, 2026
Merged
Conversation
Contributor
|
clean diff — merging this 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Accomplishments
Surfaced Connection Section: Surfaced the resolved API base URL server-side on the Settings page using
resolveApiBase()inside a new<section>component containing aKeyValueGridrow with a client-sideCopyButton.Added Messaging Copy: Updated the global translation/message catalog in
src/lib/messages.tswith Connection section descriptions.Comprehensive Test Suite:
src/app/settings/page.test.tsxchecking default values, environment overrides, copying functionality, andaria-liveannouncements, achieving 100% test coverage for the settings page.src/components/__tests__/Header.test.tsxcausing responsive navigation menu tests to fail due to closed mobile menu links.Updated Documentation: Described the Connection section and its parameters in
README.md.Multi-Commit Sequence: Committed all changes in 5 logical, sequential commits.
Verification: Executed linting, type-checking, and the full test suite successfully.
For a detailed review of all changes, please refer to the walkthrough and the task list.
Closes #142