test(lib): cover safeHref validation#210
Open
alan-provable wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
Summary
safeHrefcoverage into table-driven accept/reject cases.src/lib/url.ts.src/app/docs/page.tsxso currentmaincan typecheck and lint after the recent docs-page changes.Validation
npm run typechecknpm run lintnpx eslint src/lib/url.ts src/lib/__tests__/url.test.ts jest.config.tsnpx jest src/lib/__tests__/url.test.ts --coverage --collectCoverageFrom=src/lib/url.ts --coverageThreshold='{"./src/lib/url.ts":{"statements":100,"branches":100,"functions":100,"lines":100}}'src/lib/url.tsreached 100 percent statements, branches, functions, and lines.git diff --check origin/main..HEADKnown Baseline
npm teststill has 2 unrelated failures in untouchedsrc/components/__tests__/Header.test.tsx; the suite otherwise reports 561 passing tests and 2 skipped tests.