feat(services): adopt loading-aware Button with aria-busy for New Service submit (#151)#212
Open
GBOYEE wants to merge 1 commit into
Open
Conversation
…vice submit (Agentpay-Org#151) - Add loading prop to shared Button component - Set aria-busy when loading is true, removed on completion - Pass loading={loading} from NewServicePage to Button - Add test assertions for aria-busy state during submit
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadingprop to sharedButtoncomponentaria-busywhen loading is true, removed on completionloading={loading}fromNewServicePagetoButtonaria-busystate during submit lifecycleChanges
src/components/Button.tsx: Addedloading?: booleanprop andaria-busyattributesrc/app/services/new/page.tsx: Passloadingprop to Buttonsrc/app/services/new/page.test.tsx: Assert aria-busy is set during submit and cleared afterTest plan