Test/testing settings page#213
Open
real-venus wants to merge 2 commits into
Open
Conversation
Add page-level tests for src/app/settings/page.tsx, which previously had no coverage: - asserts the <h1> Settings heading - asserts the Appearance <h2> and its descriptive copy - asserts the ThemeToggle control (the labelled 'Theme' button group with light/dark/system options) is present - asserts the <main id="main-content"> landmark exists for the skip link - stubs window.matchMedia (absent in jsdom) so the page renders without throwing, and guards that as a regression 100% coverage of the settings page.
These pre-existing failures on main block lint/build for any PR branched from it: - src/app/docs/page.tsx used resolveApiBase() and <CurlBlock> without importing them (react/jsx-no-undef lint error + next build typecheck failure). Add the missing imports. - Two Header tests expected primary links marked aria-current twice (desktop + mobile), but the mobile nav panel only renders while open, so exactly one link is current at rest. Correct the assertions to match the component and the tests' own 'exactly one' descriptions.
Contributor
Author
|
@mikewheeleer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(settings): cover Settings page Appearance section and ThemeToggle
Closes #150
What changed
New
src/app/settings/page.test.tsx:<h1>Settings</h1>heading (by role and literal copy)<h2>and its descriptive copyThemeTogglecontrol renders — the labelled"Theme"buttongroup with
light/dark/systemoptions<main id="main-content">landmark exists for the skip linkwindow.matchMedia(absent in jsdom, read byThemeToggleviareadTheme()/effectiveTheme()) so the page renders without throwing, andguards that as an explicit regression
Coverage: 100% of
src/app/settings/page.tsx(exceeds the 95% requirement).