Test/testing tooltip#215
Open
real-venus wants to merge 2 commits into
Open
Conversation
Lock down the WCAG 2.1 SC 1.4.13 contract documented in Tooltip.tsx: - tooltip (role="tooltip") appears on mouse enter and on focus, and disappears on mouse leave and blur - stays visible while the pointer travels from the trigger onto the tooltip (hoverable) - aria-describedby on the trigger is present only while visible and points at the tooltip id, and is cleared again on hide - Escape hides the tooltip and leaves focus on the trigger (document.activeElement), while non-Escape keys are ignored - edge cases: rapid enter/leave/enter, and focus -> Escape -> re-show - collision-aware positioning: default-above, flip-below, and left/right viewport clamping 100% statements/functions/lines and 95.83% branch coverage of Tooltip.tsx.
These pre-existing failures on main block lint/build/test for any PR branched from it: - src/app/docs/page.tsx used resolveApiBase() and <CurlBlock> without importing them (react/jsx-no-undef lint error + next build typecheck failure). Add the missing imports. - Two Header tests expected primary links marked aria-current twice (desktop + mobile), but the mobile nav panel only renders while open, so exactly one link is current at rest. Correct the assertions.
Contributor
Author
|
@mikewheeleer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(components): cover Tooltip hover/focus/Escape behaviour
Closes #148
What's covered
role="tooltip") appears on mouse enter and on focus, anddisappears on mouse leave and blur
the tooltip body (WCAG 1.4.13)
aria-describedbyon the trigger is present only while visible, pointsat the tooltip
id, and is cleared again on hide(asserted via
document.activeElement); non-Escape keys are ignoredviewport clamping
Coverage of
Tooltip.tsx: 100% statements / functions / lines, 95.83%branches (exceeds the 95% requirement).