Skip to content

added props to the accordionItem #62

Merged
cunhapluiza645 merged 2 commits intomainfrom
feature/added-props-to-accordion-for-url-modification
Oct 10, 2025
Merged

added props to the accordionItem #62
cunhapluiza645 merged 2 commits intomainfrom
feature/added-props-to-accordion-for-url-modification

Conversation

@cunhapluiza645
Copy link
Copy Markdown
Contributor

@cunhapluiza645 cunhapluiza645 commented Oct 9, 2025

to control accordion with external state for url-sync

🧩 Modified Accordion Component

📸 Design Verification

image

Screenshot

Screenshot 2025-10-09 132313

Design Team Review

  • Component matches design specifications

🔄 Implementation Differences (Optional)

✅ Pre-Merge Checklist

Code Implementation

  • Component is implemented in src/components/[ComponentName]/
  • Component is properly exported in src/index.ts
  • TypeScript interfaces/types are defined and exported
  • Component follows existing code conventions and patterns
  • Component includes proper JSDoc documentation

Documentation & Communication

  • Component is documented in README.md with usage examples

@cunhapluiza645 cunhapluiza645 self-assigned this Oct 9, 2025
@github-actions github-actions bot requested a review from py-bay October 9, 2025 11:26
Copy link
Copy Markdown
Member

@EcoFreshKase EcoFreshKase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the documentation. Code looks good 👍 Main thing is that is works (which I assume it does, because you oppened the PR)

Copy link
Copy Markdown
Member

@EcoFreshKase EcoFreshKase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🥇

@cunhapluiza645 cunhapluiza645 merged commit 3441544 into main Oct 10, 2025
5 checks passed
@py-bay py-bay deleted the feature/added-props-to-accordion-for-url-modification branch October 10, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants