ISSUE #18 - [fix]: Improved logical flow of docker environment searching for laddr#23
Open
TFM-HITESH wants to merge 1 commit into
Open
ISSUE #18 - [fix]: Improved logical flow of docker environment searching for laddr#23TFM-HITESH wants to merge 1 commit into
TFM-HITESH wants to merge 1 commit into
Conversation
|
Connected to Huly®: EXAME-44 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the flow of how laddr handles docker environment initialisation and resource handling on various environments and operating systems such as Linux based, Windows based and Windows + WSL based systems.
Additionally handles the issue of
laddr initnot working on WSL systems where Docker daemon is configured over Docker Desktop.Related Issue
[BUG]: laddr run dev not working on WSL. #18
Testing (TODO)
Steps to verify that your changes work as expected:
1.
2.
3.
Type of Change
Select the type(s) of change your PR introduces:
Checklist
Before submitting, please confirm that you have:
Additional Notes
New Flow for handling docker environment handling is as follows :
NOTE: This is the planned flow for failure of docker environment being found. In case of successful docker initialisation, the framework should continue with regular happyflow steps.