This repository was archived by the owner on Dec 6, 2023. It is now read-only.
fix: add type of createScreenVideoTrack enable and disable#34
Open
wimpykid719 wants to merge 1 commit intoAgoraIO-Community:masterfrom
Open
fix: add type of createScreenVideoTrack enable and disable#34wimpykid719 wants to merge 1 commit intoAgoraIO-Community:masterfrom
wimpykid719 wants to merge 1 commit intoAgoraIO-Community:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return wrong type when I execute the following code.
createScreenVideoTrack({ encoderConfig: '480p_1' }, 'disable')()I just want to return only
ILocalVideoTrackbut this code of type tracks isILocalVideoTrack | [ILocalVideoTrack, ILocalAudioTrack]I think that's wrong because I seted withAudio: disable so never return
ILocalAudioTrackso I added two type of type for enable and disable.This is my first pull request to oss so might be something mistake or exist any other solution then please let me know.