Search nav-awareness: readable results, complete platform filter, indexed external API refs#647
Open
plutoless wants to merge 23 commits into
Open
Search nav-awareness: readable results, complete platform filter, indexed external API refs#647plutoless wants to merge 23 commits into
plutoless wants to merge 23 commits into
Conversation
… test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ted-ancestry test
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…a11y label Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…s its own tree walk) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ness # Conflicts: # src/components/docs-shell/DocsSearchDialog.test.tsx # src/components/docs-shell/DocsSearchDialog.tsx
Addresses spec-review finding: external href oddities (unreal-engine, reactjs, windows-csharp) now normalize via the registry's platformAliases instead of a separate module-local map, keeping platformRegistry the single source of truth. Behavior-identical, so the generated records artifact is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Addresses spec-review finding (design doc Section E): an external result now renders the up-right arrow next to its title, not only in the context pill. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Vercel PreviewPreview URL: https://docs-portal-nsbhip1uk-agora-devx.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three related search problems, all rooted in the Algolia index being built by a standalone, nav-blind, file-scanning path:
platformRegistry(previously three divergent lists disagreed).api-ref.agora.io) are now indexed and findable (rtc androidsurfaces the Android reference), opening in a new tab with an↗ externalaffordance.Approach
Records are now built inside the Vite payload build worker (
generate-static-docs-payload.worker.mjs), which has the resolved fumadocssource, the page tree (with externalhref/flag), and the platform registry — so breadcrumbs, platforms, and external links all come from the same authoritative source the sidebar renders from.sync-algolia-search.mjsis now a thin uploader of the emittedalgolia-records.jsonartifact (a build output; gitignored, never committed) and fails loudly if it's missing.platformRegistry(addedgo/typescript); dropdown = all registry keys ordered; server-sdk pages declareplatforms:frontmatter.rtc).↗ externalpill + new-tab open with an a11y label.Design + decision record:
docs/superpowers/specs/2026-07-04-search-nav-awareness-design.md.Documented follow-ups (non-blocking)
api-referencetab prepends its humanized tab root to breadcrumbs; other tabs get ancestor-only crumbs (product decision to revisit)./api-ref/videoand/api-ref/voiceplus ~282 scoped/dropdownai-tab pages retain graceful raw-slug breadcrumb fallback.Test Plan
bun run test src/lib/platforms/registry.test.ts src/lib/search/external-refs.test.ts src/lib/search/nav-model.test.ts src/components/docs-shell/DocsSearchDialog.test.tsx(35 passing)bun run docs:static-payload→ 1226 records; python/go/typescript resolve to["API Reference","Voice Agents"]+ correct platform; 37 external records (0 dupes);rtcpresent in the Android external record's searchable textALGOLIA_SYNC_DISABLEDguard still short-circuits first🤖 Generated with Claude Code