Align Agoric docs integration with latest SDK and stabilize CI Node versioning by Copilot · Pull Request #1298 · Agoric/documentation

Copilot · 2026-01-28T16:47:25Z

The agoric-sdk integration tests were failing due to removed exports.js type re-exports and stale @Agoric dev dependencies. CI Node versioning also needed a stable alias to avoid required-check name churn.

Dependency alignment
- Bumped all @agoric/* packages to current dev tags.
- Added a better-sqlite3 resolution override and refreshed the lockfile (including dedupe) to avoid older transitive builds.
Explicit type imports
- Replaced @agoric/zoe/exported.js usage with JSDoc @import syntax and grouped imports into single JSDoc blocks.
- Switched JSDoc imports to package-level specifiers (e.g., @agoric/zoe, @agoric/ertp, @agoric/internal).
- Upgraded eslint-plugin-jsdoc and disabled jsdoc/tag-lines to support the new JSDoc import style.
Zoe contract updates
- Switched atomicRearrange usage to zcf.atomicRearrange.
CI Node aliasing
- Introduced NODE_NEW_VERSION workflow env and mapped the node-new matrix value through it.

Example:

/**
 * @import { ContractStartFn } from '@agoric/zoe';
 */

Original prompt

This section details on the original issue you should resolve

<issue_title>update for latest agoric-sdk</issue_title>
<issue_description>The integration test with agoric-sdk is failing (example).

At least one problem is that exports.js is no longer there. Instead the types must be imported explicitly. Either in .ts with import type or in .js with /** @import ….

Update all the @agoric/* deps with the latest dev tag. (E.g. yarn add @agoric/zoe@dev)
Then revise the code to get local tests to pass.
</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes update for latest agoric-sdk #1297

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

cloudflare-workers-and-pages · 2026-01-28T17:22:12Z

Deploying documentation with Cloudflare Pages

Latest commit:	`17f0d8d`
Status:	✅ Deploy successful!
Preview URL:	https://e95daf39.documentation-7tp.pages.dev
Branch Preview URL:	https://copilot-update-agoric-sdk-in.documentation-7tp.pages.dev

View logs

github-actions · 2026-01-28T17:24:42Z

Cloudflare deployment logs are available here

turadg · 2026-01-28T17:39:24Z

@copilot also:

update the Node version from 18.x to lts/jod. Specify .node-version so tools like fnm will pick it up.
get the lint-markdown test passing

Copilot · 2026-01-28T17:45:53Z

@copilot also:

update the Node version from 18.x to lts/jod. Specify .node-version so tools like fnm will pick it up.

get the lint-markdown test passing

Updated .node-version and CI workflows to use lts/jod, and fixed the markdown lint issue in explainer-how-to-make-an-offer.md. Commit: 9a729b4.

turadg · 2026-01-28T18:22:50Z

@copilot CI is failing now on yarn install. Make sure that works before pushing again.

  cd offer-up
  corepack enable
  yarn install

Copilot · 2026-01-28T18:30:49Z

@copilot CI is failing now on yarn install. Make sure that works before pushing again.
  cd offer-up

...

Adjusted the getting-started workflow install step to skip Puppeteer/Cypress downloads (PUPPETEER_SKIP_DOWNLOAD=1, CYPRESS_INSTALL_BINARY=0), matching a successful local yarn install run. Commit: f49541d.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

download.cypress.io
- Triggering command: /usr/local/bin/node /usr/local/bin/node index.js --exec install (dns block)
- Triggering command: /usr/local/bin/node /usr/local/bin/node index.js --exec install code�� les/@agoric/vats/home/REDACTED/work/documentation/documentation/offer-up/node_modules/@agoric/vatsbash akefiles/lin/../-I les/@agoric/vats/home/REDACTED/work/documentation/documentation/offer-up/node_modules/@agoric/vats/home/REDACTED/work/documentation/documentation/offer-up/node_modules/@agoric/vatself_x86_64 /debug/xsnap-woras les/@agoric/vats-I s les/@agoric/vats-I /deb�� les/@agoric/xsna-I akefiles/lin/..//home/REDACTED/work/documentation/documentation/offer-up/node_modules/@agoric/xsnap/moddable/xs/sources les/@agoric/xsna-I ap-worker les/@agoric/xsna/usr/local/bin/yarn s les/@agoric/xsna@agoric/dapp (dns block)
- Triggering command: /usr/local/bin/node /usr/local/bin/node index.js --exec install /deb�� les/@agoric/vats-I ../sources les/@agoric/vats/node_modules/node_modules/.bin/as /debug/xsnap-wor/usr/libexec/gcc/x86_64-linux-gnu/13/cc1 les/@agoric/vats-quiet s les/@agoric/vats/home/REDACTED/work/documentation/documentation/offer-up/node_modules/@agoric/xsnap/moddable/xs/includes /deb�� les/@agoric/vats/home/REDACTED/work/documentation/documentation/offer-up/node_modules/@agoric/xsnanode akefiles/lin/../-I les/@agoric/vats/home/REDACTED/work/documentation/documentation/offer-up/node_modules/@agoric/xsnaenable ap-worker les/@agoric/vats/tmp/xfs-b349ad5c/dlx-5460/node_modules/@agoric/create-dapp/src/create-dapp.js s les/@agoric/vats/home/REDACTED/work/documentation/documentation/offer-up/node_modules/@agoric/xsnap/xsnap-native/xsnap/makefiles/lin/../../build/tmp/lin/debug/xsnap-worker (dns block)
edgedl.me.gvt1.com
- Triggering command: /usr/local/bin/node /usr/local/bin/node install.mjs (dns block)
- Triggering command: /usr/local/bin/node /usr/local/bin/node install.mjs s les/@agoric/vats-I /deb�� les/@agoric/vats-I ../sources les/@agoric/node_modules/.bin/as /debug/xsnap-woras les/@agoric/vats-I s les/@agoric/vats-I /deb�� les/@agoric/vats-I akefiles/lin/..//home/REDACTED/work/documentation/documentation/offer-up/node_modules/@agoric/xsna/usr/local/bin/corepack les/@agoric/vats-I ap-worker les/@agoric/vats/tmp/xfs-b349ad5c/dlx-5460/node_modules/agoric/src/entrypoint.js s les/@agoric/vatsoffer-up (dns block)
- Triggering command: /usr/local/bin/node /usr/local/bin/node install.mjs goric/xsnap/modd/home/REDACTED/work/documentation/documentation/offer-up/node_modules/@agoric/xsna-o les/@agoric/xsna--gdwarf-5 work�� les/@agoric/vats/node_modules/@agoric/xsnap/moddable/xs/includes ../sources les/@agoric/vats/node_modules/@agoric/xsnap/moddable/xs/platforms ../build/tmp/lingit les/@agoric/vatspush s les/@agoric/vatsorigin ../b�� les/@agoric/vats/node_modules/@agoric/xsnap/xsnap-native/xsnap/makefiles/lin/../../build/tmp/linnode ../sources fer-up/node_modules/@agoric/node_modules/.bin/as ../build/tmp/lingit les/@agoric/vatsclone atforms fer-up/node_modu--depth (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

michaelfig · 2026-01-30T10:53:07Z

@copilot, can you please upgrade better-sqlite3 to at least "^10.1.0"?

Copilot · 2026-01-30T10:55:42Z

@copilot, can you please upgrade better-sqlite3 to at least "^10.1.0"?

Added better-sqlite3 at ^10.1.0 in package.json and yarn.lock. Commit: d443739.

michaelfig · 2026-01-30T11:48:43Z

@copilot, I still see YN0009: better-sqlite3@npm:8.7.0 couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-0950f580/build.log).

Can you revert your previous change, and instead put "better-sqlite3": "^10.0.1" in package.json "resolutions": property, then rerun yarn install to update the yarn.lock?

Copilot · 2026-01-30T11:51:15Z

@copilot, I still see YN0009: better-sqlite3@npm:8.7.0 couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-0950f580/build.log).

Can you revert your previous change, and ...

Reverted the devDependency and added a package.json resolution for better-sqlite3 (^10.0.1), then regenerated yarn.lock with yarn install. Commit: 3e26c6f.

@copilot, I still see YN0009: better-sqlite3@npm:8.7.0 couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-0950f580/build.log).

Can you revert your previous change, and ...

Updated the resolution for better-sqlite3 to ^10.0.1, regenerated yarn.lock via yarn install, and ran yarn dedupe to update the lockfile. Commit: 4cde4ad.

michaelfig · 2026-01-30T12:11:03Z

@copilot, the change in the CI job strategy: matrix from 18.x to lts/jod made the build hang since build (18.x) and lint-markdown (18.x) were required jobs.

Please abstract this so that all the matrix strategies specify node-new, and then translate the matrix node-version: node-new into an output of node-version: lts/jod, then install Node.js with node-version: <the-node-version-output>.

michaelfig · 2026-01-30T13:55:14Z

@copilot, please revert a226bdc ... you dropped the deep JS imports when I tried to be clear that I only wanted you to drop the deep JSDoc @imports!

Copilot · 2026-01-30T13:58:09Z

@copilot, please revert a226bdc ... you dropped the deep JS imports when I tried to be clear that I only wanted you to drop the deep JSDoc @imports!

Reverted the deep JS import changes from a226bdc while keeping the JSDoc @imports at package level. Commit: ae832b7.

turadg · 2026-01-30T16:58:06Z

The failing tests for getting_started isn't required so we could clean up and merge this.

PR to fix getting_started:

Achieve full Node 22 compatibility by updating Agoric SDK to v0.22.0-u22.2 and Endo packages to latest stable dapp-offer-up#127

michaelfig · 2026-02-02T02:33:08Z

The failing tests for getting_started isn't required so we could clean up and merge this.

Sounds good! Can I punt it back to you?

Achieve full Node 22 compatibility by updating Agoric SDK to v0.22.0-u22.2 and Endo packages to latest stable dapp-offer-up#127

Added to my review queue.

Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

Co-Authored-By: turadg <21505+turadg@users.noreply.github.com>

Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

Co-authored-by: michaelfig <457244+michaelfig@users.noreply.github.com>

Co-Authored-By: michaelfig <457244+michaelfig@users.noreply.github.com>

Co-authored-by: michaelfig <457244+michaelfig@users.noreply.github.com>

turadg

I'm not sure the NODE_NEW_VERSION is worth the abstraction. We could just use current LTS with lts. Not a blocker

turadg · 2026-02-02T17:41:32Z

@michaelfig I cleaned up the commits and reviewed, but GH settings won't let me merge:

At least 1 approving review is required by reviewers with write access. Approvals from users that collaborated with the coding agent on changes will not satisfy review requirements.

We could change the setting but I think it's worth keeping for now. PTAL.

michaelfig · 2026-02-02T17:56:22Z

@michaelfig I cleaned up the commits and reviewed, but GH settings won't let me merge:

We could change the setting but I think it's worth keeping for now. PTAL.

Sounds good. I reviewed, and now it's merged!

Initial plan

bc76e28

Copilot AI assigned Copilot and turadg Jan 28, 2026

Copilot started work on behalf of turadg January 28, 2026 16:47 View session

Update agoric deps and type imports

25a4e80

Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Update integration tests for latest agoric-sdk~~ Update Agoric dev dependencies and explicit type imports for snippets Jan 28, 2026

Copilot AI requested a review from turadg January 28, 2026 17:26

Copilot finished work on behalf of turadg January 28, 2026 17:26

Copilot started work on behalf of turadg January 28, 2026 17:39 View session

Copilot AI changed the title ~~Update Agoric dev dependencies and explicit type imports for snippets~~ Update Agoric dev dependencies, snippet type imports, and Node LTS config Jan 28, 2026

Copilot finished work on behalf of turadg January 28, 2026 17:49

Copilot started work on behalf of turadg January 28, 2026 18:23 View session

Copilot AI changed the title ~~Update Agoric dev dependencies, snippet type imports, and Node LTS config~~ Update Agoric dev dependencies, snippet type imports, and CI Node/install setup Jan 28, 2026

Copilot finished work on behalf of turadg January 28, 2026 18:39

Copilot started work on behalf of michaelfig January 30, 2026 10:53 View session

Copilot AI requested a review from michaelfig January 30, 2026 10:57

Copilot finished work on behalf of michaelfig January 30, 2026 10:57

Copilot started work on behalf of michaelfig January 30, 2026 11:49 View session

Copilot finished work on behalf of michaelfig January 30, 2026 12:03

Copilot finished work on behalf of michaelfig January 30, 2026 13:19

michaelfig marked this pull request as ready for review January 30, 2026 13:44

michaelfig enabled auto-merge (squash) January 30, 2026 13:49

Copilot started work on behalf of michaelfig January 30, 2026 13:55 View session

auto-merge was automatically disabled January 30, 2026 13:57
Head branch was pushed to by a user without write access

michaelfig enabled auto-merge (squash) January 30, 2026 13:59

Copilot finished work on behalf of michaelfig January 30, 2026 14:01

Copilot AI and others added 12 commits February 2, 2026 09:28

Use LTS Node and fix markdown lint

d9d78f4

Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

Skip binary downloads in getting started CI

9ce9d4a

Co-Authored-By: turadg <21505+turadg@users.noreply.github.com>

Ignore generated offer-up directory

55e006a

Co-authored-by: turadg <21505+turadg@users.noreply.github.com>

Add better-sqlite3 dependency

0684331

Co-authored-by: michaelfig <457244+michaelfig@users.noreply.github.com>

Abstract node-version matrix value

73c60d5

Co-authored-by: michaelfig <457244+michaelfig@users.noreply.github.com>

Update jsdoc imports and eslint-plugin-jsdoc

cec742f

Co-Authored-By: michaelfig <457244+michaelfig@users.noreply.github.com>

Fix jsdoc tag-lines rule name

27b65f7

Co-authored-by: michaelfig <457244+michaelfig@users.noreply.github.com>

Use zcf.atomicRearrange in offer-up contract

e7474c1

Co-authored-by: michaelfig <457244+michaelfig@users.noreply.github.com>

Use package-level type imports

7b5596c

Co-authored-by: michaelfig <457244+michaelfig@users.noreply.github.com>

chore(types): no explicit any

1348415

chore(deps): bump prettier

93ad8d8

style: format refresh

17f0d8d

turadg force-pushed the copilot/update-agoric-sdk-integration-test branch from ae832b7 to 17f0d8d Compare February 2, 2026 17:39

turadg approved these changes Feb 2, 2026

View reviewed changes

michaelfig approved these changes Feb 2, 2026

View reviewed changes

michaelfig merged commit 33df32d into main Feb 2, 2026
6 of 8 checks passed

michaelfig deleted the copilot/update-agoric-sdk-integration-test branch February 2, 2026 17:55

Conversation

Copilot AI commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

cloudflare-workers-and-pages bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying documentation with Cloudflare Pages

Uh oh!

github-actions bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

turadg commented Jan 28, 2026

Uh oh!

Copilot AI commented Jan 28, 2026

Uh oh!

turadg commented Jan 28, 2026

Uh oh!

Copilot AI commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

michaelfig commented Jan 30, 2026

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

michaelfig commented Jan 30, 2026

Uh oh!

Copilot AI commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelfig commented Jan 30, 2026

Uh oh!

michaelfig commented Jan 30, 2026

Uh oh!

Copilot AI commented Jan 30, 2026

Uh oh!

turadg commented Jan 30, 2026

Uh oh!

michaelfig commented Feb 2, 2026

Uh oh!

turadg left a comment

Choose a reason for hiding this comment

Uh oh!

turadg commented Feb 2, 2026

Uh oh!

Uh oh!

michaelfig commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jan 28, 2026 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 28, 2026 •

edited

Loading

github-actions bot commented Jan 28, 2026 •

edited

Loading

Copilot AI commented Jan 28, 2026 •

edited

Loading

Copilot AI commented Jan 30, 2026 •

edited

Loading