feat: auto install bundle on instagoric

[frazarshad]

Demo video:

Screen.Recording.2024-09-11.at.8.20.06.PM.mov

Instructions to run:

• start chain using the agoric-sdk repo
  in agoric-sdk

cd packages/cosmic-swingset
make scenario2-setup   
make scenario2-run-chain  

• replace the bases/shared/instagoric-server/server.js file with this code

code

// @ts-check

import './lockdown.js';

  

import process from 'process';

import express from 'express';

import https from 'https';

import tmp from 'tmp';

import { $, fetch, fs, nothrow, sleep } from 'zx';

import multer from 'multer';

  

import { makeSubscriptionKit } from '@agoric/notifier';

  

const upload = multer({ dest: 'uploads/' });

const { details: X } = globalThis.assert;

  

const CLIENT_AMOUNT =

process.env.CLIENT_AMOUNT || '25000000uist,25000000ibc/toyusdc';

const DELEGATE_AMOUNT =

process.env.DELEGATE_AMOUNT ||

'75000000ubld,25000000ibc/toyatom,25000000ibc/toyellie,25000000ibc/toyusdc,25000000ibc/toyollie';

const DOCKERTAG = process.env.DOCKERTAG; // Optional.

const DOCKERIMAGE = process.env.DOCKERIMAGE; // Optional.

const FAUCET_KEYNAME =

process.env.FAUCET_KEYNAME || process.env.WHALE_KEYNAME || 'bootstrap';

const NETNAME = process.env.NETNAME || 'devnet';

const NETDOMAIN = process.env.NETDOMAIN || '.agoric.net';

const AG0_MODE = (process.env.AG0_MODE || 'false') === 'true';

const agBinary = AG0_MODE ? 'ag0' : 'agd';

const podname = process.env.POD_NAME || 'validator-primary';

const INCLUDE_SEED = process.env.SEED_ENABLE || 'yes';

const NODE_ID =

process.env.NODE_ID || 'fb86a0993c694c981a28fa1ebd1fd692f345348b';

const RPC_PORT = 26657;

const TRANSACTION_STATUS = {

FAILED: 1000,

NOT_FOUND: 1001,

SUCCESSFUL: 1002,

};

const agoricHome =

'~/Projects/agoric-sdk/packages/cosmic-swingset/t1/bootstrap';

  

const FAKE = process.env.FAKE || process.argv[2] === '--fake';

if (FAKE) {

console.log('FAKE MODE');

const tmpDir = await new Promise((resolve, reject) => {

tmp.dir({ prefix: 'faucet', postfix: 'home' }, (err, path) => {

if (err) {

return reject(err);

}

resolve(path);

});

});

// Create the temporary key.

console.log(`Creating temporary key`, { tmpDir, FAUCET_KEYNAME });

// await $`${agBinary} --home=${agoricHome} keys --keyring-backend=test add ${FAUCET_KEYNAME}`;

process.env.AGORIC_HOME = tmpDir;

}

  

assert(agoricHome, X`AGORIC_HOME not set`);

  

const chainId = process.env.CHAIN_ID;

assert(chainId, X`CHAIN_ID not set`);

  

let dockerImage;

  

const namespace =

process.env.NAMESPACE ||

fs.readFileSync('/var/run/secrets/kubernetes.io/serviceaccount/namespace', {

encoding: 'utf8',

flag: 'r',

});

  

const revision =

1 || process.env.AG0_MODE === 'true'

? 'ag0'

: fs

.readFileSync(

'/usr/src/agoric-sdk/packages/solo/public/git-revision.txt',

{

encoding: 'utf8',

flag: 'r',

},

)

.trim();

  

/**

* @param {string} relativeUrl

* @returns {Promise<any>}

*/

const makeKubernetesRequest = async relativeUrl => {

const ca = await fs.readFile(

'/var/run/secrets/kubernetes.io/serviceaccount/ca.crt',

'utf8',

);

const token = await fs.readFile(

'/var/run/secrets/kubernetes.io/serviceaccount/token',

'utf8',

);

const url = new URL(

relativeUrl,

'https://kubernetes.default.svc.cluster.local',

);

const response = await fetch(url.href, {

headers: {

Authorization: `Bearer ${token}`,

Accept: 'application/json',

},

agent: new https.Agent({ ca }),

});

return response.json();

};

  

const getMetricsRequest = async relativeUrl => {

const url = new URL('http://localhost:26661/metrics');

const response = await fetch(url.href);

return response.text();

};

  

// eslint-disable-next-line no-unused-vars

async function getNodeId(node) {

const response = await fetch(

`http://${node}.${namespace}.svc.cluster.local:26657/status`,

);

return response.json();

}

  

async function getServices() {

if (FAKE) {

return new Map([

['validator-primary-ext', '1.1.1.1'],

['seed-ext', '1.1.1.2'],

]);

}

const services = await makeKubernetesRequest(

`/api/v1/namespaces/${namespace}/services/`,

);

const map1 = new Map();

for (const item of services.items) {

const ingress = item.status?.loadBalancer?.ingress;

if (ingress?.length > 0) {

map1.set(item.metadata.name, ingress[0].ip);

}

}

return map1;

}

  

const getNetworkConfig = async () => {

const svc = await getServices();

const file = FAKE

? './resources/network_info.json'

: '/config/network/network_info.json';

const buf = await fs.readFile(file, 'utf8');

const ap = JSON.parse(buf);

ap.chainName = chainId;

ap.gci = `https://${NETNAME}.rpc${NETDOMAIN}:443/genesis`;

ap.peers[0] = ap.peers[0].replace(

'validator-primary.instagoric.svc.cluster.local',

svc.get('validator-primary-ext') ||

`${podname}.${namespace}.svc.cluster.local`,

);

ap.peers[0] = ap.peers[0].replace(

'fb86a0993c694c981a28fa1ebd1fd692f345348b',

`${NODE_ID}`,

);

ap.rpcAddrs = [`https://${NETNAME}.rpc${NETDOMAIN}:443`];

ap.apiAddrs = [`https://${NETNAME}.api${NETDOMAIN}:443`];

if (INCLUDE_SEED === 'yes') {

ap.seeds[0] = ap.seeds[0].replace(

'seed.instagoric.svc.cluster.local',

svc.get('seed-ext') || `seed.${namespace}.svc.cluster.local`,

);

} else {

ap.seeds = [];

}

  

return JSON.stringify(ap);

};

class DataCache {

constructor(fetchFunction, minutesToLive = 10) {

this.millisecondsToLive = minutesToLive * 60 * 1000;

this.fetchFunction = fetchFunction;

this.cache = null;

this.getData = this.getData.bind(this);

this.resetCache = this.resetCache.bind(this);

this.isCacheExpired = this.isCacheExpired.bind(this);

this.fetchDate = new Date(0);

}

  

isCacheExpired() {

return (

this.fetchDate.getTime() + this.millisecondsToLive < new Date().getTime()

);

}

  

getData() {

if (!this.cache || this.isCacheExpired()) {

console.log('fetch');

return this.fetchFunction().then(data => {

this.cache = data;

this.fetchDate = new Date();

return data;

});

} else {

console.log('cache hit');

  

return Promise.resolve(this.cache);

}

}

  

resetCache() {

this.fetchDate = new Date(0);

}

}

const ipsCache = new DataCache(getServices, 0.1);

const networkConfig = new DataCache(getNetworkConfig, 0.5);

const metricsCache = new DataCache(getMetricsRequest, 0.1);

  

const publicapp = express();

const privateapp = express();

const faucetapp = express();

const publicport = 8001;

const privateport = 8002;

const faucetport = 8003;

const logReq = (req, res, next) => {

const time = Date.now();

res.on('finish', () => {

console.log(

JSON.stringify({

time,

dur: Date.now() - time,

method: req.method,

forwarded: req.get('X-Forwarded-For'),

ip: req.ip,

url: req.originalUrl,

status: res.statusCode,

}),

);

});

next();

};

  

publicapp.use(logReq);

privateapp.use(logReq);

faucetapp.use(logReq);

  

publicapp.get('/', (req, res) => {

const domain = NETDOMAIN;

const netname = NETNAME;

res.send(`

<html><head><title>Instagoric</title></head><body><pre>

██╗███╗ ██╗███████╗████████╗ █████╗ ██████╗ ██████╗ ██████╗ ██╗ ██████╗

██║████╗ ██║██╔════╝╚══██╔══╝██╔══██╗██╔════╝ ██╔═══██╗██╔══██╗██║██╔════╝

██║██╔██╗ ██║███████╗ ██║ ███████║██║ ███╗██║ ██║██████╔╝██║██║

██║██║╚██╗██║╚════██║ ██║ ██╔══██║██║ ██║██║ ██║██╔══██╗██║██║

██║██║ ╚████║███████║ ██║ ██║ ██║╚██████╔╝╚██████╔╝██║ ██║██║╚██████╗

╚═╝╚═╝ ╚═══╝╚══════╝ ╚═╝ ╚═╝ ╚═╝ ╚═════╝ ╚═════╝ ╚═╝ ╚═╝╚═╝ ╚═════╝

  

Chain: ${chainId}${

process.env.NETPURPOSE !== undefined

? `\nPurpose: ${process.env.NETPURPOSE}`

: ''

}

Revision: ${revision}

Docker Image: ${DOCKERIMAGE || dockerImage.split(':')[0]}:${

DOCKERTAG || dockerImage.split(':')[1]

}

Revision Link: <a href="https://github.com/Agoric/agoric-sdk/tree/${revision}">https://github.com/Agoric/agoric-sdk/tree/${revision}</a>

Network Config: <a href="https://${netname}${domain}/network-config">https://${netname}${domain}/network-config</a>

Docker Compose: <a href="https://${netname}${domain}/docker-compose.yml">https://${netname}${domain}/docker-compose.yml</a>

RPC: <a href="https://${netname}.rpc${domain}">https://${netname}.rpc${domain}</a>

gRPC: <a href="https://${netname}.grpc${domain}">https://${netname}.grpc${domain}</a>

API: <a href="https://${netname}.api${domain}">https://${netname}.api${domain}</a>

Explorer: <a href="https://${netname}.explorer${domain}">https://${netname}.explorer${domain}</a>

Faucet: <a href="https://${netname}.faucet${domain}">https://${netname}.faucet${domain}</a>

Logs: <a href='https://${netname}.logs${domain}/d/aduznatawfxmob/cluster-logs?orgId=1&viewPanel=1&from=now-1m&to=now&var-userQuery=resource.labels.container_name%3D"log-slog"'>https://${netname}.logs${domain}</a>

  

UIs:

Main-branch Wallet: <a href="https://main.wallet-app.pages.dev/wallet/">https://main.wallet-app.pages.dev/wallet/</a>

Main-branch Vaults: <a href="https://dapp-inter-test.pages.dev/?network=${netname}">https://dapp-inter-test.pages.dev/?network=${netname}</a>

  

----

See more at <a href="https://agoric.com">https://agoric.com</a>

</pre></body></html>

`);

});

  

publicapp.get('/network-config', async (req, res) => {

res.setHeader('Content-type', 'text/plain;charset=UTF-8');

res.setHeader('Access-Control-Allow-Origin', '*');

const result = await networkConfig.getData();

res.send(result);

});

  

publicapp.get('/metrics-config', async (req, res) => {

res.setHeader('Content-type', 'text/plain;charset=UTF-8');

const result = await metricsCache.getData();

res.send(result);

});

  

const dockerComposeYaml = (dockerimage, dockertag, netname, netdomain) => `\

version: "2.2"

services:

ag-solo:

image: ${dockerimage}:\${SDK_TAG:-${dockertag}}

ports:

- "\${HOST_PORT:-8000}:\${PORT:-8000}"

volumes:

- "ag-solo-state:/state"

- "$HOME/.agoric:/root/.agoric"

environment:

- "AG_SOLO_BASEDIR=/state/\${SOLO_HOME:-${dockertag}}"

entrypoint: ag-solo

command:

- setup

- --webhost=0.0.0.0

- --webport=\${PORT:-8000}

- --netconfig=\${NETCONFIG_URL:-https://${netname}${netdomain}/network-config}

volumes:

ag-solo-state:

`;

  

publicapp.get('/docker-compose.yml', (req, res) => {

res.setHeader(

'Content-disposition',

'attachment; filename=docker-compose.yml',

);

res.setHeader('Content-type', 'text/x-yaml;charset=UTF-8');

res.send(

dockerComposeYaml(

DOCKERIMAGE || dockerImage.split(':')[0],

DOCKERTAG || dockerImage.split(':')[1],

NETNAME,

NETDOMAIN,

),

);

});

  

privateapp.get('/', (req, res) => {

res.send('welcome to instagoric');

});

  

privateapp.get('/ips', (req, res) => {

ipsCache.getData().then(result => {

if (result.size > 0) {

res.send(JSON.stringify({ status: 1, ips: Object.fromEntries(result) }));

} else {

res.status(500).send(JSON.stringify({ status: 0, ips: {} }));

ipsCache.resetCache();

}

});

});

  

privateapp.get('/genesis.json', async (req, res) => {

try {

const file = `/state/${chainId}/config/genesis_final.json`;

if (await fs.pathExists(file)) {

const buf = await fs.readFile(file, 'utf8');

res.send(buf);

return;

}

} catch (err) {

console.error(err);

}

res.status(500).send('error');

});

  

privateapp.get('/repl', async (req, res) => {

const svc = await ipsCache.getData();

if (svc.length > 0) {

const file = '/state/agoric.repl';

let buf = await fs.readFile(file, 'utf8');

buf = buf.replace(

'127.0.0.1',

svc.get('ag-solo-manual-ext') || '127.0.0.1',

);

res.send(buf);

} else {

res.status(500).send('error');

ipsCache.resetCache();

}

});

  

const addressToRequest = new Map();

const { publication, subscription } = makeSubscriptionKit();

const addRequest = (address, request) => {

if (addressToRequest.has(address)) {

request[0].status(429).send('error - already queued');

return;

}

console.log('enqueued', address);

addressToRequest.set(address, request);

publication.updateState(address);

};

  

/**

* Returns the status of a transaction against hash `txHash`.

* The status is one of the values from `TRANSACTION_STATUS`

* @param {string} txHash

* @returns {Promise<number>}

*/

const getTransactionStatus = async txHash => {

let { exitCode, stderr, stdout } = await nothrow($`\

${agBinary} query tx ${txHash} \

--chain-id=${chainId} \

--home=${agoricHome} \

--node=http://localhost:${RPC_PORT} \

--output=json \

--type=hash \

`);

exitCode = exitCode ?? 1;

  

// This check is brittle as this can also happen in case

// an invalid txhash was provided. So there is no reliable

// distinction between the case of invalid txhash and a

// transaction currently in the mempool. We could use search

// endpoint but that seems overkill to cover a case where

// the only the deliberate use of invalid hash can effect the user

if (exitCode && stderr.includes(`tx (${txHash}) not found`))

return TRANSACTION_STATUS.NOT_FOUND;

  

const code = Number(JSON.parse(stdout).code);

return code ? TRANSACTION_STATUS.FAILED : TRANSACTION_STATUS.SUCCESSFUL;

};

  

/**

* @param {string} address

* @param {string} clientType

* @param {string} txHash

* @returns {Promise<void>}

*/

const pollForProvisioning = async (address, clientType, txHash) => {

const status = await getTransactionStatus(txHash);

status === TRANSACTION_STATUS.NOT_FOUND

? setTimeout(() => pollForProvisioning(address, clientType, txHash), 2000)

: status === TRANSACTION_STATUS.SUCCESSFUL

? await provisionAddress(address, clientType)

: console.log(

`Not provisioning address "${address}" of type "${clientType}" as transaction "${txHash}" failed`,

);

};

  

/**

* @param {string} address

* @param {string} clientType

* @returns {Promise<void>}

*/

const provisionAddress = async (address, clientType) => {

let { exitCode, stderr } = await nothrow($`\

${agBinary} tx swingset provision-one faucet_provision ${address} ${clientType} \

--broadcast-mode=block \

--chain-id=${chainId} \

--from=${FAUCET_KEYNAME} \

--keyring-backend=test \

--keyring-dir=${agoricHome} \

--node=http://localhost:${RPC_PORT} \

--yes \

`);

exitCode = exitCode ?? 1;

  

if (exitCode)

console.log(

`Failed to provision address "${address}" of type "${clientType}" with error message: ${stderr}`,

);

};

  

/**

* Send funds to `address`.

* It only waits for the transaction

* checks and doesn't wait for the

* transaction to actually be included

* in a block. The returned transaction

* hash can be used to get the current status

* of the transaction later

* @param {string} address

* @param {string} amount

* @returns {Promise<[number, string]>}

*/

const sendFunds = async (address, amount) => {

let { exitCode, stdout } = await nothrow($`\

${agBinary} tx bank send ${FAUCET_KEYNAME} ${address} ${amount} \

--broadcast-mode=sync \

--chain-id=${chainId} \

--keyring-backend=test \

--keyring-dir=${agoricHome} \

--node=http://localhost:${RPC_PORT} \

--output=json \

--yes \

`);

exitCode = exitCode ?? 1;

  

if (exitCode) return [exitCode, ''];

return [exitCode, String(JSON.parse(stdout).txhash)];

};

  

// Faucet worker.

const startFaucetWorker = async () => {

console.log('Starting Faucet worker!');

  

try {

for await (const address of subscription) {

console.log(`dequeued address ${address}`);

const request = addressToRequest.get(address);

  

const [response, command, clientType] = request;

let exitCode = 1;

let txHash = '';

  

console.log(`Processing "${command}" for address "${address}"`);

  

switch (command) {

case 'client': {

if (!AG0_MODE) {

[exitCode, txHash] = await sendFunds(address, CLIENT_AMOUNT);

if (!exitCode) pollForProvisioning(address, clientType, txHash);

}

break;

}

case 'delegate': {

[exitCode, txHash] = await sendFunds(address, DELEGATE_AMOUNT);

break;

}

default: {

console.log('unknown command');

response.status(500).send('failure');

continue;

}

}

  

addressToRequest.delete(address);

if (exitCode === 0) {

console.log(

`Successfuly processed "${command}" for address "${address}"`,

);

response.redirect(`/transaction-status/${txHash}`);

} else {

console.log(`Failed to process "${command}" for address "${address}"`);

response.status(500).send('failure');

}

}

} catch (e) {

console.error('Faucet worker died', e);

await sleep(3000);

startFaucetWorker();

}

};

  

startFaucetWorker();

  

privateapp.listen(privateport, () => {

console.log(`privateapp listening on port ${privateport}`);

});

  

faucetapp.get('/', (req, res) => {

const clientText = !AG0_MODE

? `<input type="radio" id="client" name="command" value="client">

<label for="client">send IST and provision </label>

<select name="clientType">

<option value="SMART_WALLET">smart wallet</option>

<option value="REMOTE_WALLET">ag-solo</option>

</select>

<br>`

: '';

res.send(

`<html><head><title>Faucet</title></head><body><h1>welcome to the faucet</h1>

<form action="/go" method="post">

<label for="address">Address:</label> <input id="address" name="address" type="text" /><br>

Request: <input type="radio" id="delegate" name="command" value="delegate" checked="checked">

<label for="delegate">send BLD/IBC toy tokens</label>

${clientText}

<input type="submit" />

</form>

<br>

<br>

  

<form action="/go" method="post"><input id="address" name="address" type="hidden" value="agoric1megzytg65cyrgzs6fvzxgrcqvwwl7ugpt62346" />

<input type="hidden" name="command" value="delegate" /><input type="submit" value="fund provision pool" />

</form>

</body></html>

`,

);

});

  

faucetapp.use(

express.urlencoded({

extended: true,

}),

);

  

faucetapp.post('/go', (req, res) => {

const { command, address, clientType } = req.body;

  

if (

((command === 'client' &&

['SMART_WALLET', 'REMOTE_WALLET'].includes(clientType)) ||

command === 'delegate') &&

typeof address === 'string' &&

address.length === 45 &&

/^agoric1[0-9a-zA-Z]{38}$/.test(address)

) {

addRequest(address, [res, command, clientType]);

} else {

res.status(403).send('invalid form');

}

});

  

faucetapp.get('/api/transaction-status/:txhash', async (req, res) => {

const { txhash } = req.params;

const transactionStatus = await getTransactionStatus(txhash);

res.send({ transactionStatus }).status(200);

});

  

faucetapp.get('/transaction-status/:txhash', (req, res) => {

const { txhash } = req.params;

  

const mainPageLink = `<a href="/">Go to Main Page</a>`;

  

if (txhash)

res.status(200).send(

`

<html>

<head>

<script>

var fetchTransactionStatus = function() {

fetch("/api/transaction-status/${txhash}")

.then(async function(response) {

var json = await response.json();

if (json.transactionStatus === ${TRANSACTION_STATUS.NOT_FOUND}) setTimeout(fetchTransactionStatus, 2000);

else if (json.transactionStatus === ${TRANSACTION_STATUS.SUCCESSFUL}) document.body.innerHTML = \`

<h3>Your transaction "${txhash}" was successfull</h3>

${mainPageLink}

\`;

else

document.body.innerHTML = \`

<h3>Your transaction "${txhash}" failed</h3>

${mainPageLink}

\`;

})

.catch(function(error) {

console.log("error: ", error);

setTimeout(fetchTransactionStatus, 2000);

})

}

fetchTransactionStatus();

</script>

<style>

.loader {

animation: spin 2s linear infinite;

border: 8px solid #000000;

border-radius: 50%;

border-top: 8px solid #F5F5F5;

height: 32px;

width: 32px;

}

  

@keyframes spin {

0% { transform: rotate(0deg); }

100% { transform: rotate(360deg); }

}

</style>

<title>Faucet</title>

</head>

<body style="align-items:center; display:flex; flex-direction:column;">

<h1 style="width:100%;">Your transaction was enqueued</h1>

<p style="width:100%;">Now sit back and relax while your transaction is included in a block</p>

<div class="loader"></div>

</body>

</html>

`,

);

else res.status(400).send('invalid form');

});

  

publicapp.get('/install-bundle', async (req, res) => {

res.send(`

<!DOCTYPE html>

<html lang="en">

<head>

<meta charset="UTF-8">

<meta name="viewport" content="width=device-width, initial-scale=1.0">

<title>File Upload</title>

</head>

<body>

  

<h1>Upload a File</h1>

  

<form id="uploadForm" action="/install-bundle" method="POST" enctype="multipart/form-data">

<input type="file" name="file" id="fileInput" required>

<br><br>

<button type="submit">Upload</button>

</form>

  

<script>

document.getElementById('uploadForm').addEventListener('submit', function(event) {

event.preventDefault(); // Prevent the default form submission

  

const formData = new FormData();

const fileInput = document.getElementById('fileInput');

if (fileInput.files.length === 0) {

alert("Please select a file.");

return;

}

  

formData.append('file', fileInput.files[0]);

  

fetch('/install-bundle', {

method: 'POST',

body: formData

})

.then(response => response.json())

.then(data => {

alert('File uploaded successfully!');

console.log(data);

})

.catch(error => {

alert('Failed to upload file.');

console.error('Error:', error);

});

});

</script>

  

</body>

</html>

  

`);

});

  

publicapp.post('/install-bundle', upload.single('file'), async (req, res) => {

// Getting file from request and storing as temp file

const bundle = req.file?.filename;

console.log(bundle);

const result = await $`\

${agBinary} tx swingset install-bundle --compress "@uploads/${bundle}" \

--from ${FAUCET_KEYNAME} --keyring-backend=test --keyring-dir=${agoricHome} --gas=auto \

--chain-id=${chainId} -b block --yes

`;

console.log('\n\n', result);

if (result.exitCode !== 0) {

res.status(500).send(result.stderr);

return;

}

res.status(200).send('success');

});

  

faucetapp.listen(faucetport, () => {

console.log(`faucetapp listening on port ${faucetport}`);

});

  

if (FAKE) {

dockerImage = 'asdf:unknown';

} else {

const statefulSet = await makeKubernetesRequest(

`/apis/apps/v1/namespaces/${namespace}/statefulsets/${podname}`,

);

dockerImage = statefulSet.spec.template.spec.containers[0].image;

}

publicapp.listen(publicport, () => {

console.log(`publicapp listening on port ${publicport}`);

});

• run instagoric server
  in instagoric repo:

cd bases/shared/instagoric-server
yarn start --fake

• check bundle is not installed by checking vstorage: https://p2p-org.github.io/p2p-agoric-vstorage-viewer/#http://localhost:26657%7Cpublished%7C.bundles
• goto http://localhost:8001/install-bundle and upload a bundle file
• verify that the bundle has been installed using vstorage

[Muneeb147]

Can we have a quick working clip on PR?

[rabi-siddique]

It’s better to serve static HTML from a separate file.

publicapp.get('/install-bundle', (req, res) => {
    res.sendFile(path.join(__dirname, 'index.html'));
});

[frazarshad]

currently all static html is served from strings in this app since separate files poses some problems. we should keep it that way until we create a solution for all endpoints

[rabi-siddique]

I think we should check the response status before declaring the API request as a success.

.then(response => {
    if (!response.ok) {
        throw new Error('Failed to upload file. Server responded with status ' + response.status);
    }
    return response.json();
})

[Muneeb147]

It won't be a then if status is other than 200. So response.ok will always be true inside then.
@frazarshad Right?

[frazarshad]

correct

[rabi-siddique]

get and post have the same endpoint name. Do you think we should have distinct names?

[frazarshad]

this follows the principle of rest-api where the same type of data is handled by the same endpoint, but different operations performed on it have different methods

[usmanmani1122]

Why do we need to define action and method here if we are overriding the default browser behavior?

[frazarshad]

updated

[usmanmani1122]

Using -b block could show false positive error messages to the user

[Muneeb147]

@frazarshad

[frazarshad]

updated

[Muneeb147]

@frazarshad Regarding UI perspective, where are we exposing this option? Should it be somewhere on *.agoric.net landing page?

[frazarshad]

@Muneeb147 added a link on the main page

[Muneeb147]

If there are multiple .js and permit.json files, then it'll break as it is picking only [0]th index.

Also can we add validation if correct pair of permit.json and .js file is provided?

@toliaqat Thoughts?