fix: handle None verification in bootstrap diagnostics#30
Open
magarrent wants to merge 1 commit into
Open
Conversation
When verify_environment.py fails or produces non-JSON output,
bootstrap_environment.py stores None for the "verification" key.
In print_bootstrap_diagnostics, payload.get("verification", {})
returns None (the stored value) — the default {} only applies when
the key is absent — so the subsequent .get("notes", []) call raises:
AttributeError: 'NoneType' object has no attribute 'get'
Fix: use `(payload.get("verification") or {})` so None falls back
to an empty dict regardless of whether the key is present.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installation fails with:
Root cause
When
verify_environment.pyfails or produces non-JSON output,bootstrap_environment.pystoresNonefor the"verification"key in the result dict.In
print_bootstrap_diagnostics(install.sh), this line:calls
payload.get("verification", {})which returnsNone— the{}default only applies when the key is absent, not when it is present with valueNone. The subsequent.get("notes", [])call onNonethen raisesAttributeError.Fix
Using
or {}ensuresNonefalls back to an empty dict regardless of key presence.🤖 Generated with Claude Code