This repository was archived by the owner on Feb 12, 2025. It is now read-only.
cover local copy in restore integration test#231
Open
dmitry-potepalov wants to merge 1 commit into
Open
Conversation
Run the restore integration suite both with direct and local copy.
dmitry-potepalov
force-pushed
the
dmitry-potepalov/clickhouse/integration-test-for-restore-object-storage-files
branch
from
13eb453 to
8fba8c4
Compare
Contributor
|
Didn't get to it today, reviewing tomorrow. |
kmichel-aiven
suggested changes
Sep 2, 2024
Contributor
kmichel-aiven
left a comment
kmichel-aiven
left a comment
There was a problem hiding this comment.
I don't think we should add combinatorial explosion of parameters of the entire backup/restore integration tests.
Instead, the two copy variants should be tested by directly testing ThreadSafeRohmuStorage.copy_items_from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the restore integration suite both with direct and local copy.