5 data structure disjoint set union#148
Open
110souhei wants to merge 4 commits into
Open
Conversation
Luzhiled
reviewed
Jul 12, 2023
Comment on lines
+8
to
+9
| using isize = ptrdiff_t; | ||
| using usize = size_t; |
Member
There was a problem hiding this comment.
多分僕のライブラリから持ってきていると思うんですが、普通に int でやってもらったほうがいいと思う
Luzhiled
reviewed
Jul 12, 2023
Comment on lines
+10
to
+12
| size_t n_; | ||
|
|
||
| vector<ptrdiff_t> vals_; |
Luzhiled
reviewed
Jul 12, 2023
Comment on lines
+13
to
+20
| void bound_check(size_t v) const{ | ||
| assert(v < n_); | ||
| } | ||
|
|
||
| size_t impl_leader(size_t v){ | ||
| if( vals_[v] < 0 ) return v; | ||
| return vals_[v] = leader(vals_[v]); | ||
| } |
Member
There was a problem hiding this comment.
これも消してくれると助かる
assert は各メソッドに入れてください
Luzhiled
reviewed
Jul 12, 2023
Comment on lines
+26
to
+28
| size_t size() const{ | ||
| return n_; | ||
| } |
Luzhiled
reviewed
Jul 12, 2023
| return x; | ||
| } | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
みたいなものを入れておいてください
Luzhiled
reviewed
Jul 12, 2023
Member
There was a problem hiding this comment.
なんか全体的に tab 幅とかがおかしいと思うので space 2 つにしておいてもらえると助かります
size_t -> int tab -> space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.