refactor(app): unify log appending and remove dead code#6
Merged
primalkz merged 1 commit intoAkuaTech:masterfrom Apr 7, 2026
Merged
refactor(app): unify log appending and remove dead code#6primalkz merged 1 commit intoAkuaTech:masterfrom
primalkz merged 1 commit intoAkuaTech:masterfrom
Conversation
Remove the redundant `appendLogLine` helper method and update `executeOtaFlow`'s local `appendLog` stub to fully utilize the same `StringBuilder` + `appendTrimmed` chunking strategy used by the streaming shell. Signed-off-by: sidharthify <wednisegit@gmail.com>
sidharthify
force-pushed
the
master
branch
2 times, most recently
from
c03bb17 to
4346cdf
Compare
Contributor
Author
|
accidentally pushed different commit in between, my bad |
Member
|
Looks good, verified that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the redundant
appendLogLinehelper method and updateexecuteOtaFlow's localappendLogstub to fully utilize the sameStringBuilder+appendTrimmedchunking strategy used by the streaming shell.