Skip to content

Add show subtask#9

Open
theredcat wants to merge 4 commits into
AlJohri:mainfrom
theredcat:addShowSubtask
Open

Add show subtask#9
theredcat wants to merge 4 commits into
AlJohri:mainfrom
theredcat:addShowSubtask

Conversation

@theredcat
Copy link
Copy Markdown

Follow Up for #8 to add subtask print as well.

I've splitted thoses PR if you want to keep the simple show command without the subtask option.

@theredcat
Copy link
Copy Markdown
Author

@AlJohri This one is the more complete PR and is ready for review. I'm using it to dump tasks from asana and put them is an Elasticsearch.

My process look like this :

asana list projects --workspace=xxx | 
    jq .name| 
    xargs -I% bash -c '
        asana show tasks --project="%" --section="Dev in progress" --subtasks | 
        jq -cs "<a very long jq script that create the ES indexing bulk>"
    ' | 
    curl -X POST -H "Content-Type: application/x-ndjson" --data-binary @- "http://elastic_url:9200/index_name/_doc/_bulk"

@AlJohri
Copy link
Copy Markdown
Owner

AlJohri commented Mar 23, 2023

@theredcat nice stuff! unfortunately this project doesn't have any tests and I don't have an asana account so I can't test this, but the pull request looks small and reviewing the code it looks correct to me

I'm happy to opt for the show tasks with subtasks option-- let's keep #9 and close #8?

Also can you do a minor version bump to 0.0.4?

after that, LGTM!

@AlJohri
Copy link
Copy Markdown
Owner

AlJohri commented Mar 23, 2023

also consider updating the help text in the README's CLI section to reflect the new command

@theredcat
Copy link
Copy Markdown
Author

Yup this PR make #8 Obselete. I've orignally separated them to give you more options.

I've updated the doc, bumped the version and rebased my commits to keep them self-sufficients

@theredcat theredcat closed this Jan 22, 2024
@theredcat theredcat reopened this Jan 22, 2024
@theredcat
Copy link
Copy Markdown
Author

Hi @AlJohri Could you take a look ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants