[8.1-stable] fix(PictureThumbnail): Show spinner while images load#3694
Merged
tvdeyen merged 2 commits into8.1-stablefrom Feb 18, 2026
Merged
[8.1-stable] fix(PictureThumbnail): Show spinner while images load#3694tvdeyen merged 2 commits into8.1-stablefrom
tvdeyen merged 2 commits into8.1-stablefrom
Conversation
hoist the tooltip when nested in a ingredient editor also make the surrounding smaller so that the hoverable area is just the icon and not the whole background (cherry picked from commit ef0934d)
The connectedCallback used replaceChildren which immediately replaced the spinner with the still-loading image. Now it appends the image alongside the spinner so both are in the DOM. The existing CSS hides the image via opacity: 0 on the [loading] attribute and fades it in once the loading attribute is removed. (cherry picked from commit 42e6460)
3 tasks
tvdeyen
approved these changes
Feb 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.1-stable #3694 +/- ##
===========================================
Coverage 97.48% 97.48%
===========================================
Files 314 314
Lines 8286 8286
===========================================
Hits 8078 8078
Misses 208 208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.1-stable:Questions ?
Please refer to the Backport tool documentation