Skip to content

Add Common CardTransformReward (Needs Localization)#201

Draft
Mangochicken13 wants to merge 1 commit into
Alchyr:developfrom
Mangochicken13:CommonRewards
Draft

Add Common CardTransformReward (Needs Localization)#201
Mangochicken13 wants to merge 1 commit into
Alchyr:developfrom
Mangochicken13:CommonRewards

Conversation

@Mangochicken13
Copy link
Copy Markdown
Contributor

Adding back the removed common reward from commit #79,
This is a draft as it relies on changes to the base-game message handling so this won't conflict with any other client mods with optional messages

Alternate Design

This could also be put into a secondary library mod that flags affects_gameplay as true, with BaseLib as a dependency.
Needs discussion

@Alchyr
Copy link
Copy Markdown
Owner

Alchyr commented May 6, 2026

I rewrote custom messages, so this would need changes.
Basically, custom messages aren't "actual" messages types, instead they're all just wrapped into one of two message types, and then a patch for the IDs of those two message types to be set to custom values after all the basegame messages.

@Mangochicken13
Copy link
Copy Markdown
Contributor Author

Need to add back the images and localization (and hopefully ask for some translation help/work), but how does putting the RewardSynchronizer extension methods in the reward class feel?
Maybe makes more sense to have them in the same place, and they technically don't even need to be extension methods, since the instance could just be passed into the DoLocalTransform method, but it mirrors the base-game implementation and maybe communicates intent??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants