Add Common CardTransformReward (Needs Localization)#201
Draft
Mangochicken13 wants to merge 1 commit into
Draft
Conversation
eaadf5e to
fbbe390
Compare
Owner
|
I rewrote custom messages, so this would need changes. |
fbbe390 to
f990bfa
Compare
Contributor
Author
|
Need to add back the images and localization (and hopefully ask for some translation help/work), but how does putting the RewardSynchronizer extension methods in the reward class feel? |
f990bfa to
5af5ed7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding back the removed common reward from commit #79,
This is a draft as it relies on changes to the base-game message handling so this won't conflict with any other client mods with optional messages
Alternate Design
This could also be put into a secondary library mod that flags
affects_gameplayas true, with BaseLib as a dependency.Needs discussion