Open
Conversation
p1ho
suggested changes
May 24, 2019
p1ho
left a comment
p1ho
left a comment
There was a problem hiding this comment.
Just a single suggestion. I think this is great, and I hope it gets merged soon.
| ? message.sticker.label | ||
| : 'sticker'; | ||
|
|
||
| msg += `${' [ '.red + label } ${ x.cyan }${' ]'.red}`; |
There was a problem hiding this comment.
I would add this line right after, so you can use /v {attsNo} (like /v 0) to view the sticker in browser
atts[attsNo] = message.sticker.url;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when I when I was logged in and someone sent me a sticker, no hint of a new message appeared on the screen. Upon starting up or refreshing, stickers appeared as a blank message line. I send and receive a lot of stickers, so this kind of bugged me. This change updates the handling of stickers to display the message snippet as well as a description of the sticker, if available.