-
Notifications
You must be signed in to change notification settings - Fork 1
Add Scottish Water support to downstream impact pipeline and data docs #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ | |
| from poopy.companies import ( | ||
| AnglianWater, | ||
| NorthumbrianWater, | ||
| ScottishWater, | ||
| SevernTrentWater, | ||
|
Comment on lines
16
to
20
|
||
| SouthWestWater, | ||
| SouthernWater, | ||
|
|
@@ -66,6 +67,7 @@ | |
| "yorkshire", # Yorkshire Water | ||
| "northumbrian", # Northumbrian Water | ||
| "wessex", # Wessex Water | ||
| "scottish", # Scottish Water | ||
| "welsh", # Welsh Water | ||
| ] | ||
|
|
||
|
|
@@ -103,6 +105,8 @@ | |
| watercompany_info[company]["WaterCompany"] = NorthumbrianWater() | ||
| elif company == "wessex": | ||
| watercompany_info[company]["WaterCompany"] = WessexWater() | ||
| elif company == "scottish": | ||
| watercompany_info[company]["WaterCompany"] = ScottishWater() | ||
|
|
||
| # For each water company check that local output directory exists and create it if it doesn't | ||
| for company in watercompanies: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence updates the scope to "England and Scotland", but the README title/subtitle at the top still says the project maps discharges across England (and has a commented Wales note). Consider updating the earlier line(s) too so the README scope is consistent throughout.