Fix video playback seek storm (~1 fps on phones)#35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
videoSeek ran every animation frame during playback; each hard seek stalls the video past the 0.25s drift threshold again, cascading into a permanent seek storm. Phones show ~1 fps.
Now playback never hard-seeks on small drift: playbackRate is nudged (max 15%) to converge, hard seek only past 1s drift. Negative offsets hold the first frame until footage begins instead of clamping ahead.
Measured (headless Chromium, shot 000086): before = seek per frame; after = 1 seek total, rate settles at 1.00, video tracks chart exactly.