Skip to content

Hold playback while shot video buffers #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexNly merged 1 commit into from
Jul 16, 2026
Merged

Hold playback while shot video buffers #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/matebot/web/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function renderDetail(id, shot, compareId, compare) {
if (shot.video) {
const holder = document.createElement("div");
holder.className = "chart-card video-card";
holder.innerHTML = `<video src="${esc(shot.video)}" playsinline muted preload="metadata"></video>
holder.innerHTML = `<video src="${esc(shot.video)}" playsinline muted preload="auto"></video>
<button class="pbtn vunmute" title="Sound">🔇</button>`;
charts.appendChild(holder);
VIDEO = holder.querySelector("video");
Expand Down Expand Up @@ -171,6 +171,7 @@ function videoFollow(time, speed) {
if (VIDEO.paused) {
if (VIDEO.ended || VIDEO.currentTime >= (VIDEO.duration || Infinity)) return;
VIDEO.play().catch(() => {});
return; // no drift correction until playback actually starts
}
const drift = VIDEO.currentTime - vt;
if (Math.abs(drift) > 1) {
Expand All @@ -184,6 +185,15 @@ function videoFollow(time, speed) {
}
}

// True while the playing video is waiting for data; the chart clock holds so
// the curves never run ahead of a buffering video.
function videoBuffering(time) {
if (!VIDEO || VIDEO.error || VIDEO.ended || VIDEO.paused) return false;
const vt = time + VIDEO_OFFSET;
if (vt < 0 || vt >= (VIDEO.duration || Infinity)) return false;
return VIDEO.readyState < 3 || VIDEO.seeking;
}

function combinedChart(parent, t, phases, S, overlay) {
if (!t || t.length < 2 || typeof Chart === "undefined") return;
Chart.register(window["chartjs-plugin-annotation"]);
Expand Down Expand Up @@ -396,7 +406,7 @@ function attachPlayer(card, t, xMax, S, overlay) {

function tick(ts) {
if (lastTs != null) {
playT += ((ts - lastTs) / 1000) * Number($("#speed").value);
if (!videoBuffering(playT)) playT += ((ts - lastTs) / 1000) * Number($("#speed").value);
if (playT >= xMax) {
playT = xMax;
renderAt(playT, false);
Expand Down
Loading