Frame measurements to address hardware keyboard#1
Open
quinlijohn wants to merge 3 commits intoAlexQuinlivan:masterfrom
Open
Frame measurements to address hardware keyboard#1quinlijohn wants to merge 3 commits intoAlexQuinlivan:masterfrom
quinlijohn wants to merge 3 commits intoAlexQuinlivan:masterfrom
Conversation
…nces where an inputAccessoryView on the first responder has triggered a UIKeyboardWillShowNotification with a hardware keyboard attached.
…dware keyboard and orientation quirks.
…set, and is only ever read internally. Should it have public setters?
Author
|
There is also a question over the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe there is a bit of silliness over the way iOS handles an
inputAccessoryViewand a hardware keyboard. I’ve had issues where if there is noinputAccessoryViewon the first responder,UIKeyboardWillShowNotificationis not triggered (and so Helium correctly measures assuming an empty keyboard frame).However, when there is an
inputAccessoryViewAND a hardware keyboard, the frame provided byUIKeyboardWillShowNotificationis for the software keyboard (which is actually hidden) + the height of theinputAccessoryView(visible, but locked to the bottom of the window), and not the height of what is actually visible on the screen. This appears to cause Helium to incorrectly offset the height of views that are keyboard aware.Proposed changes are adapted from the discussion on H/W keyboards: http://stackoverflow.com/questions/2893267/how-can-i-detect-if-an-external-keyboard-is-present-on-an-ipad