Sort correlation (ρ) values by absolute magnitude#5
Merged
Alexanderlacuna merged 3 commits intomainfrom Nov 13, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the correlation computation and sorting logic to ensure that correlation coefficients (ρ) are sorted by absolute magnitude, reflecting the strength of the correlation regardless of sign.
Key changes:
** Updated custom_float_sorter to sort values by |ρ| (absolute value) instead of signed value.
** Both +∞ and -∞ are now treated as the strongest correlations and appear first (should not happen ).
** NaN values are always placed at the end of sorted lists.
Added and updated tests to verify negative correlations, magnitude-based sorting, and proper handling of NaN/∞.