Migração do axios para o módulo nativo do node#30
Open
Mauro-Domingues wants to merge 2 commits intoAlexandreBellas:developfrom
Open
Migração do axios para o módulo nativo do node#30Mauro-Domingues wants to merge 2 commits intoAlexandreBellas:developfrom
Mauro-Domingues wants to merge 2 commits intoAlexandreBellas:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salve!
Migrei o repositório https do axios para o próprio módulo nativo do node pra contribuir com o issue: Substituir axios por fetch() do próprio Javascript (o nodejs não suporta o fetch() pq ele é nativo apenas no navegador, no node temos as opções de modulos
httpehttps).O código vai funcionar direitinho mas precisa de mais testes para garantir 100%. Por exemplo, testar possíveis retornos do bling diferentes de JSON como HTML que poderiam gerar um erro na linha
79. const parsedData = JSON.parse(data);alegando que data não é um objeto válido para passar pelo.parse.E eu reparei um detalhe, os metodos
updateereplacedo repositório estão usandoPATCH. Está correto? Por garantia eu mantive ambos como estavam na branch main.