Store auth token in env#46
Open
jashapiro wants to merge 8 commits into
Open
Conversation
add a warning for the one place it moved from the previous version
Member
Before I review, this was a surprising sentence to read - are we no longer authenticating...? |
Member
Author
No, we are, just in the normal course of events it will be read from an environment variable automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
STacked on #45
I decided to wait on final downloads until I had updated to use an environment-stored token. This makes it easier to make calls with all the same token instead of having to pass it in on every call. It is also somewhat easier for users to persist tokens between sessions if desired.
Because the
auth_tokenparameter is no longer usually required, I moved it to the end of the external calls. This does breakdownload_project()if people were using positional calls, but I think that is worth the error. I added a warning to hopefully give people a reason to understand why their download folder is a uuid, but in most cases I would expect the calls to fail anyway, so the warning is just an extra. (I didn't make it an error because we do name datasets with uuids too, and I can imagine people actually using those as download directories, however rarely).