Consolidate error handling#50
Open
jashapiro wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48
Stacked on #49
This consolidates error handling to a couple of new internal functions. One replaces the calls to req_perform so we don't have to have tryCatch littered about and can use some default messages, but ones that can be easily overridden for expected errors. The other is the handler that actually does the handling, which we can use for other calls like when we used paged responses.
Because this touches so many files (mostly deleting code though!) I am filing it as a draft for now; I fully expect some modifications may be needed after other reviews and updates.