Remove Jen from template repo#189
Conversation
|
Oh no I accidentally requested copilot, I wonder what it will do! |
There was a problem hiding this comment.
Pull request overview
Removes references to “Jen O’Malley” from this training template so instructor/contact information reflects the current set of instructors.
Changes:
- Updated in-person logistics copy to direct-message one of the instructors instead of a specific individual.
- Removed Jen O’Malley from the global
instructorslist in Jekyll config.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
workshop/local-participant-information.md |
Updates the in-person “who to DM on Slack” guidance to no longer reference Jen. |
_config.yaml |
Removes Jen from the instructors list used across the site. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| The Amenity Suite is the first room you will see after exiting the elevator. | ||
| Please note that Bala Plaza is an office park with multiple buildings. | ||
| If you have trouble finding the building or the room on the first day of training, please use Slack to [direct message](/software-setup/slack-procedures.html#using-direct-messages-during-training) `Jen O'Malley`. | ||
| If you have trouble finding the building or the room on the first day of training, please use Slack to [direct message](/software-setup/slack-procedures.html#using-direct-messages-during-training) one of the instructors (`Ally Hawkins`, `Josh Shapiro`, or `Stephanie Spielman`). |
There was a problem hiding this comment.
I guess I could, but it's ugly. It would be something like this:
({% for instructor in site.instructors %}`{{ instructor }}`{% unless forloop.last %}, {% endunless %}{% endfor %})
Human reviewer gets to decide if I implement this!
There was a problem hiding this comment.
It will probably make maintenance easier in the future if we ever change instructors, so I would say this might be worth it. Especially since we already use it elsewhere.
|
Done; here's how it renders: |
| The Amenity Suite is the first room you will see after exiting the elevator. | ||
| Please note that Bala Plaza is an office park with multiple buildings. | ||
| If you have trouble finding the building or the room on the first day of training, please use Slack to [direct message](/software-setup/slack-procedures.html#using-direct-messages-during-training) `Jen O'Malley`. | ||
| If you have trouble finding the building or the room on the first day of training, please use Slack to [direct message](/software-setup/slack-procedures.html#using-direct-messages-during-training) one of the instructors ({% for instructor in site.instructors %}`{{ instructor }}`{% unless forloop.last %}{% if forloop.rindex == 2 %}, or {% else %}, {% endif %}{% endunless %}{% endfor %}). |
There was a problem hiding this comment.
ok, this is too much though.
Does what it says 😬
Found spots by running
➤ grep -r "Jen O" ., and looks to be all set now.