Skip to content

feat: use multi-select for file upload accept attribute #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sketchp1ane wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: use multi-select for file upload accept attribute #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7f7ead
feat: use multi-select for file upload accept attribute
May 18, 2026
808780d
chore: update file upload accept description
May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 80 additions & 11 deletions src/form-builder/components/edit/field-edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,16 @@ import {
DrawerTitle,
DrawerTrigger,
} from '@/components/ui/drawer'
import { Field, FieldDescription, FieldLabel } from '@/components/ui/field'
import { Input } from '@/components/ui/input'
import { Label } from '@/components/ui/label'
import {
MultiSelect,
MultiSelectContent,
MultiSelectItem,
MultiSelectTrigger,
MultiSelectValue,
} from '@/components/ui/multi-select'
import { ScrollArea } from '@/components/ui/scroll-area'
import {
Tooltip,
Expand Down Expand Up @@ -160,6 +168,72 @@ const socialMediaButtonsVariants = Object.entries(socialLogsUrls).map(
}),
)

const acceptAttributeOptions = [
'image/*',
'image/png',
'image/jpeg',
'image/gif',
'.pdf',
'application/pdf',
'.doc',
'.docx',
'.xls',
'.xlsx',
'text/csv',
'audio/*',
'video/*',
'.zip',
].map((value) => ({ value, label: value }))

function getAcceptValues(accept: unknown) {
return typeof accept === 'string'
? accept
.split(',')
.map((value) => value.trim())
.filter(Boolean)
: []
}

function AcceptAttributeMultiSelect({
value,
onChange,
}: {
value: unknown
onChange: (values: string[]) => void
}) {
const selectedValues = getAcceptValues(value)
const options = [
...acceptAttributeOptions,
...selectedValues
.filter(
(value) =>
!acceptAttributeOptions.some((option) => option.value === value),
)
.map((value) => ({ value, label: value })),
]

return (
<Field className="gap-0 [&_p]:pb-1">
<FieldLabel htmlFor="accept">Accept attribute</FieldLabel>
<FieldDescription>
Select MIME types or file extensions to accept
</FieldDescription>
<MultiSelect values={selectedValues} onValuesChange={onChange}>
<MultiSelectTrigger id="accept" className="active:scale-100">
<MultiSelectValue placeholder="image/*, audio/*, video/*, .pdf, .doc, .docx" />
</MultiSelectTrigger>
<MultiSelectContent>
{options.map((option) => (
<MultiSelectItem key={option.value} value={option.value}>
{option.label}
</MultiSelectItem>
))}
</MultiSelectContent>
</MultiSelect>
</Field>
)
}

function OptionsList({
options = [],
onChange,
Expand Down Expand Up @@ -679,18 +753,13 @@ function FormElementAttributes({
}}
form={form}
/>
<RenderFormElement
formElement={{
id: formElement.id,
name: 'accept',
placeholder: 'image/*, audio/*, video/*, .pdf, .doc, .docx',
label: 'Accept attribute',
description:
'Comma separated list of MIME types or file extensions',
fieldType: 'Input',
type: 'string',
<AcceptAttributeMultiSelect
value={form.watch('accept')}
onChange={(selectedValues) => {
form.setValue('accept', selectedValues.join(', '), {
shouldDirty: true,
})
}}
form={form}
/>
</div>
</div>
Expand Down