Iteration on AODBcRewriter#2377
Merged
sawenzel merged 2 commits intoJun 9, 2026
Merged
Conversation
Commit 28b44ef replaced the Stage 0 BC sort with an order-preserving dedup that std::abort()s unless the input BC table is already globalBC-sorted. That contradicts the tool's purpose (PURPOSE (a): repairing non-monotonic fGlobalBC in merged AO2Ds), so it aborted on exactly the files it exists to fix -- the "doesn't run to completion" regression. Revert only that Stage 0 change (restore stage0_sortBCs, drop the abort). Keep 28b44ef's Stage 1b track regrouping and the fIndexTracks* remaps: that mechanism is the correct fix for the -1-group split from b11cd3d (track fIndexCollisions values were remapped but rows left in input order, so per-collision groups -- including the -1 ambiguous group -- were no longer contiguous, tripping ArrowTableSlicingCache::validateOrder downstream). It only ever failed because the aborting Stage 0 stopped it running. Sorting BCs implies a BC -> collisions (Stage 1) -> tracks (Stage 1b) reorder cascade, which those stages now handle completely. Add a validator check (checkCollisionGroupContiguity) mirroring O2's slicing invariant: every fIndexCollisions group must be one contiguous run. Added a history note in Stage 0 against re-introducing the order-preserving abort. Not yet validated against a real merged AO2D / analysis task. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still WIP, opened for preview