Skip to content

[PWGHF] feat(taskLcToK0sP): add THnSparse with ML scores, align with taskLc patterns#16492

Merged
zhangbiao-phy merged 10 commits into
AliceO2Group:masterfrom
dongfangqingxin:master
Jun 2, 2026
Merged

[PWGHF] feat(taskLcToK0sP): add THnSparse with ML scores, align with taskLc patterns#16492
zhangbiao-phy merged 10 commits into
AliceO2Group:masterfrom
dongfangqingxin:master

Conversation

@dongfangqingxin

Copy link
Copy Markdown
Contributor

Add THnSparse support for Λc→K0sP analysis with BDT scores (Data, MC Rec, MC Gen). Add process functions for standard/ML with FT0C/FT0M centrality estimators. Refactor code structure to align with taskLc.cxx."

@github-actions github-actions Bot added the pwghf PWG-HF label Jun 1, 2026
@github-actions github-actions Bot changed the title feat(taskLcToK0sP): add THnSparse with ML scores, align with taskLc patterns [PWGHF] feat(taskLcToK0sP): add THnSparse with ML scores, align with taskLc patterns Jun 1, 2026
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

dongfangqingxin added a commit to dongfangqingxin/O2Physics that referenced this pull request Jun 1, 2026
Please consider the following formatting changes to AliceO2Group#16492
@vkucera vkucera marked this pull request as draft June 1, 2026 21:31
@vkucera

vkucera commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Fix the reported issues.

…atterns

Add THnSparse support for Λc→K0sP analysis with BDT scores (Data,
MC Rec, MC Gen). Add process functions for standard/ML with FT0C/FT0M
centrality estimators. Refactor code structure to align with taskLc.cxx.
@vkucera

vkucera commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

@dongfangqingxin Thanks for the fixes. You have overwritten the formatting changes four times. Please learn how to update your local branch and/or how to format your local changes automatically to avoid it.

@dongfangqingxin

Copy link
Copy Markdown
Contributor Author

@dongfangqingxin Thanks for the fixes. You have overwritten the formatting changes four times. Please learn how to update your local branch and/or how to format your local changes automatically to avoid it.

Hi @vkucera Thanks for the heads-up and sorry for the back-and-forth. I've installed clang-format locally now, will make sure to run it before pushing next time.

@vkucera

vkucera commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

@dongfangqingxin Thanks for the fixes. You have overwritten the formatting changes four times. Please learn how to update your local branch and/or how to format your local changes automatically to avoid it.

Hi @vkucera Thanks for the heads-up and sorry for the back-and-forth. I've installed clang-format locally now, will make sure to run it before pushing next time.

You don't need to install and run it separately, if you're using the pre-commit hooks.

@dongfangqingxin

Copy link
Copy Markdown
Contributor Author

@dongfangqingxin Thanks for the fixes. You have overwritten the formatting changes four times. Please learn how to update your local branch and/or how to format your local changes automatically to avoid it.

Hi @vkucera Thanks for the heads-up and sorry for the back-and-forth. I've installed clang-format locally now, will make sure to run it before pushing next time.

You don't need to install and run it separately, if you're using the pre-commit hooks.

Ah, I see — thanks for the tip! I hadn't set up the pre-commit hooks. I'll activate them now to avoid this in the future.

@vkucera vkucera marked this pull request as ready for review June 2, 2026 07:27
@zhangbiao-phy

Copy link
Copy Markdown
Collaborator

Thanks @dongfangqingxin! The changes are good to me!

@zhangbiao-phy zhangbiao-phy merged commit 168c4f5 into AliceO2Group:master Jun 2, 2026
13 checks passed
jjuracka pushed a commit to jjuracka/O2Physics that referenced this pull request Jun 6, 2026
…taskLc patterns (AliceO2Group#16492)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
@vkucera

vkucera commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

You are supposed to verify your includes.

PWGHF/D2H/Tasks/taskLcToK0sP.cxx:71:54: warning: no header providing "o2::aod::EvSels" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:73:75: warning: no header providing "o2::aod::CentFT0Cs" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:75:75: warning: no header providing "o2::aod::CentFT0Ms" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:476:11: warning: no header providing "int8_t" is directly included [misc-include-cleaner]

@dongfangqingxin

Copy link
Copy Markdown
Contributor Author

You are supposed to verify your includes.

PWGHF/D2H/Tasks/taskLcToK0sP.cxx:71:54: warning: no header providing "o2::aod::EvSels" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:73:75: warning: no header providing "o2::aod::CentFT0Cs" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:75:75: warning: no header providing "o2::aod::CentFT0Ms" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:476:11: warning: no header providing "int8_t" is directly included [misc-include-cleaner]

Hi @vkucera, Thanks for your comments. I didn't get these warnings on my machine, but I believe they can be fixed by adding the following includes:

#include <cstdint>                               // for int8_t
#include "Common/DataModel/Centrality.h"         // for CentFT0Cs, CentFT0Ms
#include "Common/DataModel/EventSelection.h"     // for EvSels

I will push a commit and see if the CI passes. Please let me know if you have any further suggestions.

@vkucera

vkucera commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

You are supposed to verify your includes.

PWGHF/D2H/Tasks/taskLcToK0sP.cxx:71:54: warning: no header providing "o2::aod::EvSels" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:73:75: warning: no header providing "o2::aod::CentFT0Cs" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:75:75: warning: no header providing "o2::aod::CentFT0Ms" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:476:11: warning: no header providing "int8_t" is directly included [misc-include-cleaner]

Hi @vkucera, Thanks for your comments. I didn't get these warnings on my machine, but I believe they can be fixed by adding the following includes:

#include <cstdint>                               // for int8_t
#include "Common/DataModel/Centrality.h"         // for CentFT0Cs, CentFT0Ms
#include "Common/DataModel/EventSelection.h"     // for EvSels

I will push a commit and see if the CI passes. Please let me know if you have any further suggestions.

How did you verify the list of includes?

@dongfangqingxin

Copy link
Copy Markdown
Contributor Author

You are supposed to verify your includes.

PWGHF/D2H/Tasks/taskLcToK0sP.cxx:71:54: warning: no header providing "o2::aod::EvSels" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:73:75: warning: no header providing "o2::aod::CentFT0Cs" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:75:75: warning: no header providing "o2::aod::CentFT0Ms" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:476:11: warning: no header providing "int8_t" is directly included [misc-include-cleaner]

Hi @vkucera, Thanks for your comments. I didn't get these warnings on my machine, but I believe they can be fixed by adding the following includes:

#include <cstdint>                               // for int8_t
#include "Common/DataModel/Centrality.h"         // for CentFT0Cs, CentFT0Ms
#include "Common/DataModel/EventSelection.h"     // for EvSels

I will push a commit and see if the CI passes. Please let me know if you have any further suggestions.

How did you verify the list of includes?
Hi @vkucera, Thank you for the reminder.
I cross-checked with existing tasks in the same directory, such as PWGHF/D2H/Tasks/taskLc.cxx and taskCharmPolarisation.cxx, and also located the necessary tables in Common/DataModel/Centrality.h and Common/DataModel/EventSelection.h.

@vkucera

vkucera commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

You are supposed to verify your includes.

PWGHF/D2H/Tasks/taskLcToK0sP.cxx:71:54: warning: no header providing "o2::aod::EvSels" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:73:75: warning: no header providing "o2::aod::CentFT0Cs" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:75:75: warning: no header providing "o2::aod::CentFT0Ms" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:476:11: warning: no header providing "int8_t" is directly included [misc-include-cleaner]

Hi @vkucera, Thanks for your comments. I didn't get these warnings on my machine, but I believe they can be fixed by adding the following includes:

#include <cstdint>                               // for int8_t
#include "Common/DataModel/Centrality.h"         // for CentFT0Cs, CentFT0Ms
#include "Common/DataModel/EventSelection.h"     // for EvSels

I will push a commit and see if the CI passes. Please let me know if you have any further suggestions.

How did you verify the list of includes?
Hi @vkucera, Thank you for the reminder.
I cross-checked with existing tasks in the same directory, such as PWGHF/D2H/Tasks/taskLc.cxx and taskCharmPolarisation.cxx, and also located the necessary tables in Common/DataModel/Centrality.h and Common/DataModel/EventSelection.h.

That is not how you are supposed to do that. Follow the instructions. https://aliceo2group.github.io/analysis-framework/docs/tools/#cleaning-include-statements-and-using-statements

@dongfangqingxin

Copy link
Copy Markdown
Contributor Author

You are supposed to verify your includes.

PWGHF/D2H/Tasks/taskLcToK0sP.cxx:71:54: warning: no header providing "o2::aod::EvSels" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:73:75: warning: no header providing "o2::aod::CentFT0Cs" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:75:75: warning: no header providing "o2::aod::CentFT0Ms" is directly included [misc-include-cleaner]
PWGHF/D2H/Tasks/taskLcToK0sP.cxx:476:11: warning: no header providing "int8_t" is directly included [misc-include-cleaner]

Hi @vkucera, Thanks for your comments. I didn't get these warnings on my machine, but I believe they can be fixed by adding the following includes:

#include <cstdint>                               // for int8_t
#include "Common/DataModel/Centrality.h"         // for CentFT0Cs, CentFT0Ms
#include "Common/DataModel/EventSelection.h"     // for EvSels

I will push a commit and see if the CI passes. Please let me know if you have any further suggestions.

How did you verify the list of includes?
Hi @vkucera, Thank you for the reminder.
I cross-checked with existing tasks in the same directory, such as PWGHF/D2H/Tasks/taskLc.cxx and taskCharmPolarisation.cxx, and also located the necessary tables in Common/DataModel/Centrality.h and Common/DataModel/EventSelection.h.

That is not how you are supposed to do that. Follow the instructions. https://aliceo2group.github.io/analysis-framework/docs/tools/#cleaning-include-statements-and-using-statements

Hi @vkucera Thank you very much for the clarification and guidance. I will follow the instructions in the documentation to properly clean up the include statements. Then I will update in the new PR once I have done it correctly.

fjonasALICE pushed a commit to fjonasALICE/O2Physics that referenced this pull request Jun 9, 2026
…taskLc patterns (AliceO2Group#16492)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

4 participants