fix: preserve web upload auto frame titles#16
Open
CircleCrop wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
frame.titlewhen showing fallback/full m2ts titles, losing the original automatic title; the UI must be able to switch presentation without mutating the upload plan.Description
UploadPlanTitleDisplayModeand exposingautoTitleandfullTitleonFramePreviewRow, while leavingWebUploadFramePlan.titleunchanged (files changed:web-upload-view-model.ts).buildPlanViewto accept atitleDisplayModeparam and populatetitle,autoTitle, andfullTitleaccordingly (option A implemented at view-model layer).planRefimmutable and store the currenttitleDisplayModein React state; toggling rebuilds the PlanView from the originalWebUploadPlanrather than mutating it (file changed:web-upload-workbench.tsx).PairingPreviewPanelwith mode-aware copy that switches between使用完整 m2ts-帧号and恢复自动帧号and wired it to the workbench toggle handler (file changed:web-upload-pairing-preview.tsx).web-upload-view-model.test.tsverifying switching to full titles and restoring back preserves the original automaticframe.title.Testing
pnpm --filter @magic-compare/internal-site test -- web-upload-view-model.test.tsand fixed an initial parse mismatch; after the fix the test file passed.pnpm --filter @magic-compare/internal-site testand all tests passed (120 passed).pnpm --filter @magic-compare/internal-site lint), typecheck (pnpm --filter @magic-compare/internal-site typecheck) and applied formatting withprettier; those checks completed without errors.Codex Task