Closed
Conversation
…eviously worked correctly only for "start=0" argument. Now it works correctly for any value of "start" argument
To see how serious its effect can be, run 3waves.py and observe that the continuous and sampled outputs don't overlap if the former code is used!
jay-woo
added a commit
to jay-woo/ThinkDSP
that referenced
this pull request
Feb 5, 2015
jay-woo
added a commit
to jay-woo/ThinkDSP
that referenced
this pull request
Feb 5, 2015
| ts = numpy.linspace(0, self.duration, n) | ||
| dt = 1.0 / self.framerate | ||
| ts = numpy.arange(self.start, self.start + self.duration, dt) | ||
| # Due to erroneous division, the ts calculated above and below |
Owner
There was a problem hiding this comment.
Waves now carry the ts around with them, so I think this is resolved.
Owner
|
I think these are all resolved now. Thanks very much! |
Smektych
added a commit
to Smektych/ThinkDSP
that referenced
this pull request
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sir, please go through my commits, where I have clearly mentioned the changes I have done.
You can then merge the branches if you are convinced.