Apply Wave.shift() to output wav file#91
Open
zhufengning wants to merge 1 commit intoAllenDowney:masterfrom
Open
Apply Wave.shift() to output wav file#91zhufengning wants to merge 1 commit intoAllenDowney:masterfrom
zhufengning wants to merge 1 commit intoAllenDowney:masterfrom
Conversation
Adjust `zs` when `ts` doesn't start from zero
Owner
|
Thanks for this suggestion, but I'm not sure I understand the motivation. What problem does this solve? |
Author
|
Wave.shift adds the value to ts array, but when writing wav file, it doesn't consider values in ts array, so it will write a not shifted wav file. |
Owner
|
Should the wav file be shifted? What goes wrong if it's not? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust
zswhentsdoesn't start from zero