IgorException::HandleException: Output message for debug only#75
Open
t-b wants to merge 1 commit into
Open
Conversation
Since forever we always outputted zmq library errors to the history. While this is convenient for debugging, it is a bin annoying for users. So let's move that type of message to debug output. We still return with a runtime error though.
There was a problem hiding this comment.
Pull request overview
This pull request changes how IgorException reports its message when handled, shifting exception output from normal logging to debug-only logging.
Changes:
- Switched
IgorException::HandleException()output fromNORMAL_OUTPUTtoDEBUG_OUTPUT.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since forever we always outputted zmq library errors to the history. While this is convenient for debugging, it is a bin annoying for users.
So let's move that type of message to debug output.
We still return with a runtime error though.