Fix starters for Weight Dequantization Problem#167
Open
zinchse wants to merge 1 commit intoAlphaGPU:mainfrom
Open
Fix starters for Weight Dequantization Problem#167zinchse wants to merge 1 commit intoAlphaGPU:mainfrom
zinchse wants to merge 1 commit intoAlphaGPU:mainfrom
Conversation
fix inconsistent starters for Weight Dequantization Problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The starter code for the Weight Dequantization problem has an incorrect function signature that doesn't match the test runner's expectations
To reproduce the issue (e.g. in Pytorch) submit the default starter code to see the error "TypeError: solve() takes 4 positional arguments but 6 were given. Test case failed"
Users must manually fix the function signature before being able to test their solution. While this is a minor fix, it creates confusion and breaks the out-of-box experience.
What I've done: I've updated starter code for Pytorch, Cute, Mojo, and Triton to include the missing M and N parameters. After quickly reviewing the eval code, I believe they share the same call signature. I also verified from the user side and testing confirmed the runner does pass 6 arguments in all cases. However, I have not thoroughly audited the entire codebase - please verify no other dependencies are affected by this change.
P.S. Submitting the unmodified starter explicitly crashes in Pytorch, Cute, and Triton. Mojo doesn't crash with the wrong signature, so I verified it separately by printing the arguments: