Skip to content

Conversation

@salimsara
Copy link
Contributor

📄 Pull Request Overview

Closes #604

🔧 Changes Made

Updated IClan interface to keep it up to date with the current Clan API. Added new required fields and updated the roles field to use a new exported type.

Changes:

  • Added
    • roles -> IClanRole[] type
    • goal
    • clanLogo
    • battlePoints
    • language
    • points
    • ageRange
  • Removed
    • join_message from IJoin

Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected.
  • JSDoc: I have added or updated JSDoc comments for all relevant code.
  • Debugging: No console.log() or other debugging statements are left.
  • Clean Code: Removed commented-out or unnecessary code.
  • Tests: Added new tests or updated existing ones for the changes made.
  • Documentation: Documentation has been updated (if applicable).

📝 Additional Information

Provide any additional context or information that reviewers may need to know:

  • Screenshots: [Include any screenshots or videos if the changes affect the UI]
  • Dependencies: [Mention any new dependencies or breaking changes]
  • Known Issues: [List any known issues or limitations]

Copy link
Member

@Skoivumaki Skoivumaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should now work 👍

@Skoivumaki
Copy link
Member

@jartsanull
Review

@jartsanull
Copy link
Contributor

Good job!
You updated the file very well!

Copy link
Contributor

@Rutjake Rutjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@Rutjake Rutjake merged commit 2a261a3 into dev Jan 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants