Skip to content

Conversation

@patinen
Copy link
Contributor

@patinen patinen commented Jan 29, 2026

📄 Pull Request Overview

Closes #586

🔧 Changes Made

  1. Migrated API calls to V2 collections (members_v2, teams_v2, departments_v2)
  2. Refactored to roles-based structure: Members now have roles[] array containing team/department info instead of direct fields
  3. Fixed translation field names (name instead of team/department) and updated TypeScript types
  4. Refactored organizeMembers to reduce complexity and fix linter errors

Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected.
  • JSDoc: I have added or updated JSDoc comments for all relevant code.
  • Debugging: No console.log() or other debugging statements are left.
  • Clean Code: Removed commented-out or unnecessary code.
  • Tests: May need updates for new structure
  • Documentation: Updated

📝 Additional Information

Provide any additional context or information that reviewers may need to know:

  • Members can now have multiple roles and appear in multiple teams/departments
  • Breaking change: Member interface now uses roles[] instead of direct team/department fields

Copy link
Member

@Skoivumaki Skoivumaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple "credits" page is starting to get quite complex. I find using JS native let variable odd in a TS Next enviroment, but from what I found. Using it in loops and similar, is acceptable or even preferred over constants. (Unless the entire logic was originally built around them const, which probably wouldnt be as readable...)
Anyway, good work as always👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants