Skip to content

fix: redundant/double scrollbar in bottom sheet (e.g. MCP view) #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
laileni-aws wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −4
Draft

fix: redundant/double scrollbar in bottom sheet (e.g. MCP view) #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4555fe1
fix: avoid redundant scrollbar in sheet (MCP view double scrollbar)
laileni-aws Jul 15, 2026
c43d398
chore: coerce evaluate result to boolean in quick-action header flow
laileni-aws Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/styles/components/_sheet.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@
border-radius: 0;
height: 100%;
overflow-x: hidden;
overflow-y: scroll;
// Only show the scrollbar when content overflows, avoiding a permanent
// (often empty) scrollbar in the fullscreen sheet.
overflow-y: auto;
}

> .mynah-card-body {
Expand Down Expand Up @@ -126,7 +128,11 @@
gap: var(--mynah-sizing-4);
align-items: stretch;
flex: 1;
overflow-y: scroll;
// Use auto so the scrollbar only appears when the content actually
// overflows. With 'scroll' the sheet body always renders a scrollbar,
// which combined with the inner scrollable list (e.g. the MCP view)
// produced a redundant second scrollbar wrapping the whole panel.
overflow-y: auto;
overflow-x: hidden;
> .mynah-sheet-header-status {
box-shadow: none;
Expand Down
4 changes: 2 additions & 2 deletions ui-tests/__test__/flows/quick-action-commands-header.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,9 @@ export const verifyQuickActionCommandsHeaderStatusVariations = async (page: Page
let foundStatusClass = false;

for (const statusClass of statusClasses) {
const hasStatus = await headerElement.evaluate((el, className) =>
const hasStatus = Boolean(await headerElement.evaluate((el, className) =>
el.classList.contains(className), statusClass
);
));
if (hasStatus) {
foundStatusClass = true;
console.log(`Found status class: ${statusClass}`);
Expand Down
Loading